Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-ledger-conformance: Remove CHANGELOG.md from cabal file #3907

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Dec 4, 2023

Currently empty.

Description

Without this file, this repository cannot be used as a source-package-repository because:

> cabal build all
HEAD is now at a62edfae6 CI: Add ghc-9.8.1 to the build matrix
Error: cabal: sdist of cardano-ledger-conformance-0.1.0.0: filepath wildcard
'CHANGELOG.md' does not match any files.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead remove CHANGELOG.md from the cabal file, because this package will never be released, thus changelog makes little sense with absence of releasing and versioning

@erikd erikd force-pushed the conformance-changelog branch from d86e182 to 6b1c72a Compare December 4, 2023 22:35
@erikd erikd changed the title cardano-ledger-conformance: Add CHANGELOG.md cardano-ledger-conformance: Remove CHANGELOG.md from cabal file Dec 4, 2023
This package will never be released so does not need changelog.
@erikd erikd force-pushed the conformance-changelog branch from 6b1c72a to 4f599fc Compare December 4, 2023 22:37
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lehins lehins enabled auto-merge December 4, 2023 22:39
@lehins lehins merged commit c26b3f8 into master Dec 5, 2023
@iohk-bors iohk-bors bot deleted the conformance-changelog branch December 5, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants