Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream testing instances for very basic types #3908

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jasagredo
Copy link
Contributor

Description

Use Arbitrary and ToExpr from upstream. Enables IntersectMBO/ouroboros-consensus#517

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for doing this!!!

libs/cardano-ledger-binary/cardano-ledger-binary.cabal Outdated Show resolved Hide resolved
@lehins
Copy link
Contributor

lehins commented Dec 5, 2023

@jasagredo Sorry, my suggestion was not properly formatted according to cabal 😭

@jasagredo jasagredo force-pushed the js/use-upstream-instances branch 2 times, most recently from 003faa4 to 3fb63f7 Compare December 5, 2023 15:27
@jasagredo jasagredo merged commit 6b8e07f into master Dec 6, 2023
11 of 26 checks passed
@iohk-bors iohk-bors bot deleted the js/use-upstream-instances branch December 6, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants