Removed call to tail, and the 'watchPulser' test #3912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test causes a failure on Master
TASTY_PATTERN='/Watch pulser on traces of length 120./' cabal test --test-options "--quickcheck-replay=433821"
to make a step test, where we test a property on every (state{n}, state{n+1}) pair in trace we used the following pattern
pairs = zip states (tail states)
But in very rare occasions, when the number of states is 0 or 1, tail raises the empty List error.
We can easily fix this by pattern matching, and return true when that is the case.
We also removed the '/Watch pulser on traces of length 120./' test, which uses trace and prints too much stuff.
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)