Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5222 Remove ApplicationName and ApplicationVersion config parameters #5240

Merged
merged 2 commits into from
Jun 2, 2023
Merged

#5222 Remove ApplicationName and ApplicationVersion config parameters #5240

merged 2 commits into from
Jun 2, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 12, 2023 •
edited
Loading

Description

This PR removes unnecessary configuration parametes from cardano-node config.
#5222
Requires IntersectMBO/cardano-api#8
see also: https://input-output-rnd.slack.com/archives/CCRB7BU8Y/p1683739407050779

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 9ccc531 to c818825 Compare May 15, 2023 18:17
@carbolymer carbolymer marked this pull request as ready for review May 15, 2023 18:19
@carbolymer carbolymer marked this pull request as draft May 15, 2023 18:24
@carbolymer carbolymer mentioned this pull request May 15, 2023
Closed
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from c818825 to 948559c Compare May 16, 2023 10:58
@hamishmack hamishmack force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 948559c to e33d069 Compare May 17, 2023 00:32
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch 6 times, most recently from 12b1454 to 737fe6e Compare May 26, 2023 09:54
@carbolymer carbolymer marked this pull request as ready for review May 26, 2023 09:56
@Jimbo4350 Jimbo4350 self-requested a review May 26, 2023 13:56
Jimbo4350
Jimbo4350 requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5240 (comment)

@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch 2 times, most recently from 5c719e8 to 7640b08 Compare May 26, 2023 16:02
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 7640b08 to 7b442c9 Compare May 26, 2023 16:22
CarlosLopezDeLara
CarlosLopezDeLara approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@carbolymer
Copy link
Contributor Author

Hydra build failures are unrelated to this PR, they will be fixed by: https://github.com/input-output-hk/cardano-node/pull/5274/files

@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 7b442c9 to 99e3100 Compare June 1, 2023 08:02
@carbolymer carbolymer requested a review from a team as a code owner June 1, 2023 08:02
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch 2 times, most recently from 452226c to 0c30a88 Compare June 1, 2023 18:08
@carbolymer carbolymer force-pushed the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch from 0c30a88 to f7902ed Compare June 1, 2023 19:05
@angerman
Copy link
Contributor

angerman commented Jun 1, 2023

What happens if those keys are still in the config file? Does this produce a sensible error message, or simply ignore them?

@Jimbo4350
Copy link
Contributor

What happens if those keys are still in the config file? Does this produce a sensible error message, or simply ignore them?

They are ignored. No need to produce an error message because they are legacy Byron parameters.

@carbolymer carbolymer enabled auto-merge June 2, 2023 15:51
@carbolymer carbolymer added this pull request to the merge queue Jun 2, 2023
Merged via the queue into master with commit 2e7f9d9 Jun 2, 2023
@iohk-bors iohk-bors bot deleted the mgalazyn/feature/remove-applicationname-applicationversion-cfg-params branch June 2, 2023 18:47
@carbolymer carbolymer mentioned this pull request Jun 13, 2023
Closed
@johnalotoski johnalotoski mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@CarlosLopezDeLara CarlosLopezDeLara CarlosLopezDeLara approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@deepfire deepfire Awaiting requested review from deepfire

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carbolymer @angerman @Jimbo4350 @disassembler @CarlosLopezDeLara