Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 8.10.0-pre, nixpkgs bump, plus misc #36

Merged
merged 18 commits into from
Apr 12, 2024
Merged

Conversation

johnalotoski
Copy link
Collaborator

@johnalotoski johnalotoski commented Apr 1, 2024

Overview:

  • Sets cardano-[node|cli]-ng to 8.10.0-pre, dbsync-ng to sancho-4.1.0; bumps nixpkgs (23.11) and nixpkgs-unstable; improves, adds new and fixes a number of just recipes; allows repo custom recipes to be kept as a separate import for easy justfile maintenance; refactors ip module checking into its own nixosModule and adds an extra abort option for safety.

Details:

  • Bumps nixpkgs (23.11) and nixpkgs-unstable updates, ex: for just version update
  • Bumps node/cli/etc -ng versions to 8.10.0-pre
  • Bumps dbsync-ng for sancho-4.1.0
  • Bumps [node|cli]-ng and associated node -ng packages to 8.10.0-pre
  • Changes intra-cluster localRoots to default to trustable true in cardano-node topologies
  • Enables blockperf nixosModule compatibility with dnsmasq for /etc/hosts lookups
  • Adds downstream-[diff|patch] recipes for cardano-parts to ingest downstream improvements
  • Adds template recipe reminder to check node version urls during book generation
  • Adds template save-bulk-creds recipe for easily generating prior generation bulk creds during respin
  • Adds template sanity checks to recipe update-ips during ip module generation
  • Adds template support for upcoming peerSharing env default and new nodeConfigBp iohk-nix PR code
  • Adds template ip-modules-check nixosModule to move ip checking out of colmena.nix
  • Adds template deleg amount param to setup deleg script
  • Fixes template tofu plan diff for ssh config between just recipes
  • Fixes template update-ips recipe when starting from clean state
  • Fixes template template-diff fail when upstream file exists but local doesn't
  • Fixes template terraform cluster missing stateVersion AMI images w/ nixpkgs lib ver, unstable pin
  • Fixes template cardano-node dashboard block utilization for the proper full max block size
  • Moves repo custom recipes to a separate import for ease of diffing and patch the main justfile
  • Adds a cluster flakeModule option abortOnMissingIpModule for extra safety:
#   flake.cardano-parts.cluster.infra.generic.abortOnMissingIpModule     # boolean to enable or disable an abort if ip-module nixosModule is missing

Breaking Changes, Recommended Updates and Action Items:

Breaking:

  • The justfile template now includes an import statement, but this needs an updated version of just before it will work, so after bumping the cardano-parts pin of your repo, ensure you reload your devshell and the just is version 1.25.2 before continuing. The prior devshell just version 1.16.0 will no longer load the latest Justfile template.

Recommended Updates:

  • To make updating (diff and patching) the main Justfile easier, it is recommended to move any repo custom recipes that are not already part of the cardano-parts template Justfile into the scripts/custom-recipes.just file of your repo. If this file exists, it will automatically be loaded and imported into the full just recipe list.

  • The ip module check code which was previously part of the flake/colmena.nix template for downstream repos has been enhanced and refactored into its own nixosModule which will exist in the downstream repo: flake/nixosModules/ip-module-check.nix. The old code should be removed from the colmena.nix file and the new ip-module-check.nix nixosModule added. This will be accomplished in the action item list below.

  • A new cluster option of abortOnMissingIpModule was added and defaults to true so that if a downstream ip-module nixosModule is missing, nixosConfiguration builds will abort rather than simply warn and sometimes succeed. This is to avoid unintentional deployment and breaking of live machine and/or cluster services if someone fails to notice a missing ip-module warning or doesn't understand the significance and still proceeds to deploy machines anyway. For clusters that are not using the downstream ip-module generated with just tofu update-ips, this option along with warnOnMissingIpModule can be set false.

Action Items:

  • Diff and patch the following files with just template-diff "$FILE" and then just template-patch "$FILE". Looking at the short PR diff for these files found at directory templates/cardano-parts-project/ prior to diffing and patching against your own repo can also be helpful.
Justfile                                # For new recipes, updates, fixes, refactor
flake/cluster.nix                       # For new `abortOnMissingIpModule` option
flake/colmena.nix                       # For ip module check refactoring
flake/nixosModules/ip-module-check.nix  # For new ip module check code
flake/opentofu/cluster.nix              # For latest aws AMI images
scripts/custom-recipes.just             # For new repo local custom recipes refactor
scripts/setup-delegation-accounts.py    # For delegation parameter option

@johnalotoski johnalotoski merged commit d234f7c into main Apr 12, 2024
2 checks passed
@johnalotoski johnalotoski changed the title Next 2024 04 01 Node 8.10.0-pre, private/sancho respins, nixpkgs bump Apr 12, 2024
@johnalotoski johnalotoski changed the title Node 8.10.0-pre, private/sancho respins, nixpkgs bump Node 8.10.0-pre, nixpkgs bump, plus misc Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant