-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 8.10.0-pre, nixpkgs bump, plus misc #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fef623d
to
9ec83e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
8.10.0-pre
, dbsync-ng tosancho-4.1.0
; bumps nixpkgs (23.11) and nixpkgs-unstable; improves, adds new and fixes a number of just recipes; allows repo custom recipes to be kept as a separate import for easy justfile maintenance; refactors ip module checking into its own nixosModule and adds an extra abort option for safety.Details:
8.10.0-pre
sancho-4.1.0
8.10.0-pre
trustable
true in cardano-node topologies/etc/hosts
lookupssave-bulk-creds
recipe for easily generating prior generation bulk creds during respinupdate-ips
during ip module generationnodeConfigBp
iohk-nix PR codeabortOnMissingIpModule
for extra safety:Breaking Changes, Recommended Updates and Action Items:
Breaking:
1.25.2
before continuing. The prior devshell just version1.16.0
will no longer load the latestJustfile
template.Recommended Updates:
To make updating (diff and patching) the main
Justfile
easier, it is recommended to move any repo custom recipes that are not already part of the cardano-parts templateJustfile
into thescripts/custom-recipes.just
file of your repo. If this file exists, it will automatically be loaded and imported into the full just recipe list.The ip module check code which was previously part of the
flake/colmena.nix
template for downstream repos has been enhanced and refactored into its own nixosModule which will exist in the downstream repo:flake/nixosModules/ip-module-check.nix
. The old code should be removed from the colmena.nix file and the new ip-module-check.nix nixosModule added. This will be accomplished in the action item list below.A new cluster option of
abortOnMissingIpModule
was added and defaults totrue
so that if a downstreamip-module
nixosModule is missing, nixosConfiguration builds will abort rather than simply warn and sometimes succeed. This is to avoid unintentional deployment and breaking of live machine and/or cluster services if someone fails to notice a missing ip-module warning or doesn't understand the significance and still proceeds to deploy machines anyway. For clusters that are not using the downstream ip-module generated withjust tofu update-ips
, this option along withwarnOnMissingIpModule
can be set false.Action Items:
just template-diff "$FILE"
and thenjust template-patch "$FILE"
. Looking at the short PR diff for these files found at directorytemplates/cardano-parts-project/
prior to diffing and patching against your own repo can also be helpful.