This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Disable existing Plutus prototype #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
approved these changes
Dec 12, 2018
| txScriptCheck txSigData twValidator twRedeemer | ||
| -- The existing blockchain should not have any witnesses of this | ||
| -- type, so checking should just fail using the following. | ||
| Left $ WitnessScriptVerMismatch (scrVersion twValidator) (scrVersion twRedeemer) |
|
Can we drop |
|
@avieth I will have a another attempt at removing plutus-prototype as a dependency. |
erikd
force-pushed
the
erikd/CBR-492
branch
2 times, most recently
from
6cf2a2d
to
a2f1bf3
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 13, 2018
3952: Disable existing Plutus prototype r=erikd a=erikd ## Description The code base included support for the Plutus prototype, but these were officially only for testing on a test net and that if transactions showed up on mainnet containing smart contract, there would be no guarantees about them. Testing shows that there are no smart contracts in the mainnet chain. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-493 ## QA Steps Synced the whole mainnet blockchain with this version of the code. 3957: Implement Update endpoints for the Node API r=parsonsmatt a=parsonsmatt ## Description This PR implements the node update endpoints. ## Linked issue There's a change to the implementation of the API. The decision is covered here: cardano-foundation/cardano-wallet#151 3963: [DEVOPS-1184] Prevent OSX from building unncessary nix-tools r=disassembler a=disassembler * Only require nix-tools linux passing for required jobset * only run cross tests on windows ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com> Co-authored-by: parsonsmatt <parsonsmatt@gmail.com> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Timed out (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 14, 2018
3952: Disable existing Plutus prototype r=erikd a=erikd ## Description The code base included support for the Plutus prototype, but these were officially only for testing on a test net and that if transactions showed up on mainnet containing smart contract, there would be no guarantees about them. Testing shows that there are no smart contracts in the mainnet chain. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-493 ## QA Steps Synced the whole mainnet blockchain with this version of the code. 3957: Implement Update endpoints for the Node API r=parsonsmatt a=parsonsmatt ## Description This PR implements the node update endpoints. ## Linked issue There's a change to the implementation of the API. The decision is covered here: cardano-foundation/cardano-wallet#151 Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com> Co-authored-by: parsonsmatt <parsonsmatt@gmail.com>
Canceled (will resume) |
|
bors r- |
Canceled |
|
bors r+ p=10 |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 14, 2018
3952: Disable existing Plutus prototype r=disassembler a=erikd ## Description The code base included support for the Plutus prototype, but these were officially only for testing on a test net and that if transactions showed up on mainnet containing smart contract, there would be no guarantees about them. Testing shows that there are no smart contracts in the mainnet chain. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-493 ## QA Steps Synced the whole mainnet blockchain with this version of the code. Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Build failed |
The existing version of Plutus was just a prototype and there were never any guarantees made that scripts using this version of Plutus would ever be supported. This means the current blockchain should not have any transactions containing smart contracts (ie Plutus).
These transactions require the Plutus and the current version of Plutus is not officially supported.
The current version of Plutus is only a prototype and is not supported for anything other than testing.
The `ScriptWitness` constructor in this code base is no longer supported.
|
bors p=0 |
|
bors r+ p=0 |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 15, 2018
3952: Disable existing Plutus prototype r=erikd a=erikd ## Description The code base included support for the Plutus prototype, but these were officially only for testing on a test net and that if transactions showed up on mainnet containing smart contract, there would be no guarantees about them. Testing shows that there are no smart contracts in the mainnet chain. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-493 ## QA Steps Synced the whole mainnet blockchain with this version of the code. Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code base included support for the Plutus prototype, but these were officially only for testing on a test net and that if transactions showed up on mainnet containing smart contract, there would be no guarantees about them. Testing shows that there are no smart contracts in the mainnet chain.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-493
QA Steps
Synced the whole mainnet blockchain with this version of the code.