This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1184] Prevent OSX from building unncessary nix-tools #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverca22
approved these changes
Dec 13, 2018
jbgi
approved these changes
Dec 13, 2018
disassembler
force-pushed
the
devops-1184-disable-nix-tools-required
branch
2 times, most recently
from
21123ef
to
f9fa8de
Compare
* Only require nix-tools linux passing for required jobset * only run cross tests on windows
disassembler
force-pushed
the
devops-1184-disable-nix-tools-required
branch
from
f9fa8de
to
9b7f310
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 13, 2018
3960: Remove wallet submodule r=disassembler a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> I'll just have removed the submodule today (morning) as we discussed for it appears not to be ideal for people outside cardano-wallet. Development of feature will start diverging between cardano-wallet and cardano-sl after a while and after the scope of sl has been decided. In the end, we'd be wasting efforts trying to move the current CI infrastructure to cardano-wallet, not mentioning the trouble for exchanges to migrate. In particular, I wasn't aware that we were planning only one more release on the legacy code; hence, there's no such thing as a transition period. ## Linked issue <!--- Put here the relevant issue from YouTrack --> 3963: [DEVOPS-1184] Prevent OSX from building unncessary nix-tools r=disassembler a=disassembler * Only require nix-tools linux passing for required jobset * only run cross tests on windows ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Build failed (retrying...) |
|
bors r+ |
|
Not awaiting review |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 13, 2018
3952: Disable existing Plutus prototype r=erikd a=erikd ## Description The code base included support for the Plutus prototype, but these were officially only for testing on a test net and that if transactions showed up on mainnet containing smart contract, there would be no guarantees about them. Testing shows that there are no smart contracts in the mainnet chain. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-493 ## QA Steps Synced the whole mainnet blockchain with this version of the code. 3957: Implement Update endpoints for the Node API r=parsonsmatt a=parsonsmatt ## Description This PR implements the node update endpoints. ## Linked issue There's a change to the implementation of the API. The decision is covered here: cardano-foundation/cardano-wallet#151 3963: [DEVOPS-1184] Prevent OSX from building unncessary nix-tools r=disassembler a=disassembler * Only require nix-tools linux passing for required jobset * only run cross tests on windows ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com> Co-authored-by: parsonsmatt <parsonsmatt@gmail.com> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Timed out (retrying...) |
|
bors r+ |
|
Not awaiting review |
|
bors r+ p=10 |
|
Not awaiting review |
|
bors p=10 |
|
bors r- |
Canceled |
|
bors r+ p=10 |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 14, 2018
3963: [DEVOPS-1184] Prevent OSX from building unncessary nix-tools r=disassembler a=disassembler * Only require nix-tools linux passing for required jobset * only run cross tests on windows ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.