Skip to content

Conversation

cong-or
Copy link
Contributor

@cong-or cong-or commented Oct 12, 2023

Fragment generator in byte format. As per specification.

The original idea was to isolate and rewrite a bare bones version of the specification from scratch to verify the spec and our existing implementation. This was largely done except for the cryptography. The encrypted vote part is manageable to rewrite and somewhat standard.

However the ZKP proof is not, the algorithm from the treasury paper is NOVEL and difficult to recreate with external off the shelf libs. An isolated ZKP implementation with no baggage in the context of cat-core requires a rewrite from scratch as there is no existing libs suitable; any rewrite is basically a mirror of our existing cryptography and vote crates in cat-core.

In any case, we need to use the binary of this crate within the context of our load tester. We can potentially come back to alternatives implementation of the ZKP stuff in the future.

@cong-or cong-or changed the title feat: fragment generator feat: fragment generator | NGP-000 Oct 12, 2023
@cong-or cong-or changed the title feat: fragment generator | NGP-000 feat: Fragment generator | NPG-0000 Oct 12, 2023
@cong-or cong-or requested review from Mr-Leshiy and kukkok3 October 13, 2023 10:07
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cong-or cong-or merged commit 8dfce7c into main Oct 13, 2023
@cong-or cong-or deleted the fragment-generator branch October 13, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants