Skip to content

Update add_account() function interface #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

Update add_account() function interface #794

merged 1 commit into from
Apr 7, 2022

Conversation

Mr-Leshiy
Copy link
Contributor

Remove implicit clone() execution inside, so in some places we can get rid of uneeded copy operations.

ecioppettini
ecioppettini approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@ecioppettini ecioppettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an operation in the Hamt that calls clone lazily if the entry does not exist, but that would probably too complicated to be worth it.

@Mr-Leshiy
Copy link
Contributor Author

@Enzoc4 , Will try do it but maybe in the separate PR

@Mr-Leshiy Mr-Leshiy merged commit f635809 into master Apr 7, 2022
@Mr-Leshiy Mr-Leshiy deleted the ledger-update branch April 7, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ecioppettini ecioppettini ecioppettini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mr-Leshiy @ecioppettini