Update ByteCode type, change Vec<u8> to Box<[u8]> #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
requested review from
zeegomo and
saibatizoku
and removed request for
zeegomo
saibatizoku
approved these changes
May 3, 2022
saibatizoku
pushed a commit
that referenced
this pull request
May 11, 2022
saibatizoku
added a commit
that referenced
this pull request
May 11, 2022
* update rlp crate, expose it via chain-evm * add ethereum crate to cargo manifest in chain-evm * rlp encoding for evm transactions update tests for evm transaction serialization bijection * add AccessList type and impl rlp en/de updates tests and vm function signatures * impl rlp::Encodable for EvmTransaction * use AccessList and AccessListItem types from ethereum crate replaces handmade vec of tuples * implement Encodable/Decodabe traits for EvmTransaction adds test for RLP bijection, ignores previous bijection test * expose chain_evm::Config thru chain-impl-mockchain * implement RLP encoding under the hood for Payload/DeserializeFromSlice uses common traits for fragment ser/de with RLP encoding for EVM transactions * clean up lints, make clippy happy * add feature gate for evm serialize_in function * clean clippy lint * move import used only in tests * make utility function for access list conversation into private * impl Serialize n Deserialize for EvmTransaction remove DeserializeFromSlice, as we get a blanket impl now * update evm transaction serialization bijection test * more test coverage to evm transaction RLP ser/de * serialize length of RLP bytes Co-authored-by: Enzo Cioppettini <48031343+enzoc4@users.noreply.github.com> * serialize length of RLP bytes in Serialize trait Co-authored-by: Enzo Cioppettini <48031343+enzoc4@users.noreply.github.com> * read expected RLP bytes from Codec Co-authored-by: Enzo Cioppettini <48031343+enzoc4@users.noreply.github.com> * test no longer applies * arbitrary AccessList is either empty or has 4 items Co-authored-by: Alex Pozhylenkov <leshiy12345678@gmail.com> * add EthereumTransaction type implements RLP encoding/decoding implements Serialize/Deserialize from chain_core * add unsigned transaction types, implement RLP decoding brings in secp256k1 crate dependency * adds signed and unsigned tx support for Ethereum includes tests from https://eips.ethereum.org/EIPS/eip-155#example * fix clippy errors * sign and recover transactions also adds tests for the Secret type, which holds a SecretKey and offers helpful conversions * repair signed tx recovery, improve tests * few corrections to doc strings * refactor signed tx recovery, tidy up code a bit * Add transactions related scenarios (#790) * added ledger status validation after transaction scenario * removed useless validation * added scenario for invalid transaction * added scenarios for correct fees when casting & tallying votes * partial PR correction * PR corrections * deleted comment * PR corrections * change Vec<u8> to Box<[u8]> (#803) * cleanup code, add docs, handle errors * update EvmTransaction encoding for Box[u8] bytecode Co-authored-by: Enzo Cioppettini <48031343+enzoc4@users.noreply.github.com> Co-authored-by: Alex Pozhylenkov <leshiy12345678@gmail.com> Co-authored-by: Nicolo' Padovani <69471887+nicopado@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.