Skip to content

fix and refactor validate_ledger test #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix and refactor validate_ledger test #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions chain-impl-mockchain/src/testing/e2e/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub fn validate_ledger_state_after_transaction(amount: Random1to10, linear_fee:
pub fn validate_ledger_state_after_invalid_transaction(amount: Random1to10, linear_fee: LinearFee) {
let total_fees = linear_fee.calculate(None, 1, 1);
let valid_transaction_amount = total_fees.0 + amount.0;
let alice_initial_balance = amount.0 + valid_transaction_amount + total_fees.0;
let alice_initial_balance = valid_transaction_amount + total_fees.0;
let bob_initial_balance = BASIC_BALANCE;

let (mut ledger, controller) = prepare_scenario()
Expand All @@ -68,28 +68,21 @@ pub fn validate_ledger_state_after_invalid_transaction(amount: Random1to10, line
let bob = controller.wallet("Bob").unwrap();

controller
.transfer_funds(
&alice,
&bob,
&mut ledger,
valid_transaction_amount + total_fees.0,
)
.transfer_funds(&alice, &bob, &mut ledger, alice_initial_balance)
.unwrap();

alice.confirm_transaction();

// this second transaction should fail as alice does not have the balance to cover for it
let _ = controller.transfer_funds(
&alice,
&bob,
&mut ledger,
valid_transaction_amount + total_fees.0,
);
let _ = controller.transfer_funds(&alice, &bob, &mut ledger, alice_initial_balance);

alice.confirm_transaction();

LedgerStateVerifier::new(ledger.clone().into())
.address_has_expected_balance(alice.as_account_data(), Value(0));

LedgerStateVerifier::new(ledger.into()).address_has_expected_balance(
alice.as_account_data(),
Value(alice_initial_balance - (valid_transaction_amount + total_fees.0)),
bob.as_account_data(),
Value(bob_initial_balance + valid_transaction_amount),
);
}