Implement revision urls, drop "index/" url #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
May 30, 2023
| targets <- prepareIndexPkgMetadata expiryTime ppv | ||
| let path = outputDir </> "index" </> prettyShow pkgName </> prettyShow pkgVersion </> "package.json" |
There was a problem hiding this comment.
We're now no longer writing this file anywhere? Does that matter?
There was a problem hiding this comment.
I don't think it ever mattered. I don't think hackage serves it either.
michaelpj
approved these changes
May 30, 2023
It should be safe; but you just made be think that I didn't serve the latest cabal file anymore so I put that back under the hackage url ( |
andreabedini
added a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Jul 7, 2023
The /index paths where removed in input-output-hk/foliage#63
disassembler
pushed a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Jul 10, 2023
The /index paths where removed in input-output-hk/foliage#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58