-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flakify repository to prepare for CI integration #19
Conversation
1d98601
to
a11c410
Compare
a11c410
to
adf1bd8
Compare
it fixes the flakes build
since the command `nix develop -c "cabal repl"` doesn't seem to work
8b7030b
to
ff63112
Compare
only one task that builds everything
888144f
to
56faf15
Compare
do not use flattenTree from flake-utils as that forces the build
Can we disable the three errors where there is no builder available somehow? Or will there be a builder in the future? Also, the darwin build fails because of this: |
Looks like something is broken about the darwin builders more generally? This time it fails with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad that the tests now all succeed! The only thing that I'd still want before this is merged is to not use nix flakes for building the code. I don't know enough about them to comfortably maintain that myself, and I also don't want to tell people to enable experimental features to work with this repo.
@WhatisRT Would it suffice to add flake-compat so that people can build without enabling flakes? We could revert everything back to the pre-flake way and then import it back into the flake. Not sure that's worth it though as pretty much every other repo is now flakified which would make this one an exception. |
The bigger issue for me is really the ability to maintain it myself. In my experience, whenever I need to ask for help with anything nix related, it takes forever to get something done. By looking at that flake, I get the impression that most of the things I don't understand in there are related to CI, so maybe separating out CI related things into its own file and adding |
close this? |
Yeah, since we now have a working CI I'll close this for now. If we ever want to add Cicero we can revisit this. |
This is preparation for cicero integration.