Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakify repository to prepare for CI integration #19

Closed
wants to merge 19 commits into from

Conversation

disassembler
Copy link

This is preparation for cicero integration.

@disassembler disassembler force-pushed the sl/flakify branch 2 times, most recently from 1d98601 to a11c410 Compare October 7, 2022 15:16
@dermetfan dermetfan force-pushed the sl/flakify branch 5 times, most recently from 8b7030b to ff63112 Compare October 11, 2022 12:30
@dermetfan dermetfan requested a review from teodanciu October 11, 2022 12:35
@WhatisRT
Copy link
Collaborator

Can we disable the three errors where there is no builder available somehow? Or will there be a builder in the future?

Also, the darwin build fails because of this:
MidnightExample-docs> error: path '/nix/store/011r8qs3ggg40mp58gmnhyyygnhyfybf-texlive-datetime2-irish-1.1' is not valid
That error looks to me like garbage collection happened too quickly? Ledger-docs also uses this package, and it's there at that time.

@dermetfan
Copy link
Contributor

@dermetfan dermetfan requested a review from WhatisRT December 2, 2022 21:10
@WhatisRT
Copy link
Collaborator

WhatisRT commented Dec 5, 2022

Looks like something is broken about the darwin builders more generally? This time it fails with

Agda-ledger-MidnightExample-hs-src> client_loop: send disconnect: Broken pipe
error: unexpected end-of-file

Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that the tests now all succeed! The only thing that I'd still want before this is merged is to not use nix flakes for building the code. I don't know enough about them to comfortably maintain that myself, and I also don't want to tell people to enable experimental features to work with this repo.

@dermetfan
Copy link
Contributor

@WhatisRT Would it suffice to add flake-compat so that people can build without enabling flakes? We could revert everything back to the pre-flake way and then import it back into the flake. Not sure that's worth it though as pretty much every other repo is now flakified which would make this one an exception.

@WhatisRT
Copy link
Collaborator

The bigger issue for me is really the ability to maintain it myself. In my experience, whenever I need to ask for help with anything nix related, it takes forever to get something done.

By looking at that flake, I get the impression that most of the things I don't understand in there are related to CI, so maybe separating out CI related things into its own file and adding flake-compat might work for me as well. And I assume that if it doesn't then actually reverting to the old default.nix would be a small change to that.

@jmchapman
Copy link

close this?

@WhatisRT
Copy link
Collaborator

WhatisRT commented Mar 3, 2023

Yeah, since we now have a working CI I'll close this for now. If we ever want to add Cicero we can revisit this.

@WhatisRT WhatisRT closed this Mar 3, 2023
@WhatisRT WhatisRT deleted the sl/flakify branch August 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants