-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Agda 2.6.3 #50
Conversation
🎉 🎊 🍾 |
30a0a6d
to
d403d29
Compare
d403d29
to
8ee2cec
Compare
"...It also means we don't have to rely on a custom patched version of Agda anymore." That is great news! 💯 👏🏼 ...although, this branch doesn't type-check for me yet. I'll try to diagnose/fix it today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are very minor---just pointing out that some imports are not used---so I'll approve the PR and leave it up to you whether or not to remove the unnecessary imports before merging.
nix-shell --command "cabal repl --build-depends 'agda-ledger-executable-spec, agda-ledger-executable-spec-midnight'" | ||
λ> :m HSLedgerTest | ||
λ> main | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not include the emacs config instructions on the main README as well as CONTRIBUTING? I think they're very useful and harder to find if they're only in CONTRIBUTING.
src/Axiom/Set/Map.agda
Outdated
@@ -18,7 +18,7 @@ import Data.Sum | |||
open import Data.List.Ext.Properties | |||
open import Data.Product.Properties | |||
open import Interface.DecEq | |||
open import Relation.Nullary.Negation using (¬?) | |||
open import Relation.Nullary.Decidable using (¬?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems ¬?
is not used. Can we delete this import?
I think we can also delete the following imports from src/Axiom/Set/Map.agda
:
open import Axiom.Set.Factor th
import Data.List
src/Axiom/Set/Rel.agda
Outdated
@@ -17,7 +17,7 @@ import Data.Sum | |||
open import Data.List.Ext.Properties | |||
open import Data.Product.Properties | |||
open import Interface.DecEq | |||
open import Relation.Nullary.Negation using (¬?) | |||
open import Relation.Nullary.Decidable using (¬?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here. We could remove the following imports from src/Axiom/Set/Rel.agda
:
open import Axiom.Set.Factor th
import Data.List
open import Relation.Nullary.Decidable using (¬?)
@@ -20,7 +20,7 @@ open import Data.List.Relation.Binary.Permutation.Propositional | |||
open import Data.List.Relation.Unary.Unique.Propositional | |||
open import Interface.DecEq | |||
open import Relation.Binary hiding (Rel) | |||
open import Relation.Nullary.Negation using (¬?) | |||
open import Relation.Nullary.Decidable using (¬?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In src/Axiom/Set/Sum.agda
I think we can remove the following:
import Data.Sum
open Equivalence
@@ -15,8 +15,6 @@ open import Relation.Binary renaming (Decidable to Decidable²) | |||
open import Relation.Binary.PropositionalEquality | |||
open import Relation.Nullary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From src/Interface/Decidable/Instance.agda
we can remove the following:
open import Data.List
open import Data.List.Properties
open import Relation.Nullary
As well as the variable P
in the private variable
declarations.
@@ -20,7 +20,6 @@ import Data.Unit.Polymorphic | |||
open import Data.Product.Properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From src/Ledger/PPUp/Properties.agda
we could remove some imports.
open import Ledger.Epoch
open import Tactic.ReduceDec
open import MyDebugOptions
More unused imports: In In
|
82772b0
to
7a2e791
Compare
Update ledger & the dependencies to Agda 2.6.3. This gives us a few nice things, in particular some improvements to metaprogramming and potentially quotients via erased cubical. It also means we don't have to rely on a custom patched version of Agda anymore.