Skip to content

Remove the System.IO.Seek module for Windows #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Remove the System.IO.Seek module for Windows #5

merged 1 commit into from
Mar 21, 2023

Conversation

jorisdral
Copy link
Contributor

The System.IO.Seek module is redundant from ghc-8.10.7 onwards.

@jorisdral jorisdral requested a review from a team March 17, 2023 15:09
@jorisdral jorisdral self-assigned this Mar 17, 2023
@jorisdral jorisdral force-pushed the jdral/remove-seek-module branch from 8f86b5f to 96c805f Compare March 17, 2023 15:52
@jorisdral jorisdral marked this pull request as ready for review March 17, 2023 16:00
@dnadales
Copy link
Contributor

Should we specify in the readme that this package works with ghc-8.10.7 onwards?

@jorisdral
Copy link
Contributor Author

jorisdral commented Mar 21, 2023 •
edited
Loading

Should we specify in the readme that this package works with ghc-8.10.7 onwards?

I'll add to the README that the package is unlikely to work with GHC versions before ghc-8.10.7. The *.cabal files will list which specific versions we test in our CI

@jorisdral jorisdral force-pushed the jdral/remove-seek-module branch from 96c805f to f6a4598 Compare March 21, 2023 11:53
@jorisdral jorisdral force-pushed the jdral/remove-seek-module branch from f6a4598 to 3011dc3 Compare March 21, 2023 13:42
@jorisdral jorisdral merged commit ed36f48 into main Mar 21, 2023
@jorisdral jorisdral deleted the jdral/remove-seek-module branch March 24, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadales dnadales dnadales approved these changes

Assignees

@jorisdral jorisdral

Labels
None yet
Projects
No open projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisdral @dnadales