Skip to content

configureFlags must be a list in newer nixpkgs #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

considerate
Copy link
Contributor

When compiling against the musl ABI with isStatic = true the following line throws an error because configureFlags is assumed to be a list:
https://github.com/NixOS/nixpkgs/blob/7cd9f4e83350c564bb3c0a2da80677d97cef5d4c/pkgs/stdenv/adapters.nix#L66

@michaelpj
Copy link
Collaborator

Do we need a conditional for older versions of nixpkgs, or does this work on old versions too?

@considerate
Copy link
Contributor Author

considerate commented Mar 11, 2022

Do we need a conditional for older versions of nixpkgs, or does this work on old versions too?

As far as I can tell the older versions should be able to use the list. A git grep 'configureFlags = [' on the nixos-18.09 branch of nixpkgs results in a lot of hits. If not I thought CI would catch it (provided that it would run on all versions since 21.05).

I don't really know how to go about testing if it is explicitly required to pass a plain list in earlier versions of nixpkgs other than just trying to build with them.

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Mar 12, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 12, 2022

try

Build failed:

@hamishmack hamishmack merged commit 185dc16 into input-output-hk:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants