Skip to content

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Dec 16, 2022

to properly support inputMap keys without rev.

Before this commit I got errors like:

error: attribute 'ref' missing

       at /nix/store/byfll3yha4clnqif577vv3mlii5f9p5h-source/lib/call-cabal-project-to-nix.nix:227:71:

          226|               then
          227|                 (if inputMap.${repoData.url}.rev != (__trace repoData repoData.ref)
             |                                                                       ^
          228|                   then throw "${inputMap.${repoData.url}.rev} may not match ${repoData.ref} for ${repoData.url} use \"${repoData.url}/${repoData.ref}\" as the inputMap key if ${repoData.ref} is a branch or tag that points to ${inputMap.${repoData.url}.rev}."
       Did you mean rev?

when specifying inputsMap keys from only the url (no rev).

 to properly support inputMap keys without rev.
@jbgi jbgi requested a review from hamishmack December 16, 2022 16:29
@fumieval
Copy link

fumieval commented Jan 6, 2023

@michaelpj @hamishmack Could you take a look? This is blocking us from upgrading haskell.nix for a cabal project

@hamishmack hamishmack merged commit c22fb2e into master Jan 7, 2023
@iohk-bors iohk-bors bot deleted the fix-input-map-support-with-no-rev branch January 7, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants