Skip to content

Improve collectComponents #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

Improve collectComponents #463

merged 1 commit into from
Feb 28, 2020

Conversation

michaelpj
Copy link
Collaborator

Fixes #457.

  • Components that don't have a library component will no longer break
    collectComponents "library".
  • Avoid having lots of empty attribute sets.
  • Don't set recurseForDerivations excessively.

@michaelpj
Improve collectComponents
d2ff775 
Fixes #457.

- Components that don't have a library component will no longer break
`collectComponents "library"`.
- Avoid having lots of empty attribute sets.
- Don't set `recurseForDerivations` excessively.
angerman
angerman approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hamishmack hamishmack merged commit 2aa1329 into master Feb 28, 2020
@angerman angerman deleted the imp/collectComponents branch March 2, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packages that consist of just an executable break collectComponents
3 participants
@michaelpj @angerman @hamishmack