Skip to content

Tidy ci.nix using dimension #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Tidy ci.nix using dimension #500

merged 2 commits into from
Mar 20, 2020

Conversation

michaelpj
Copy link
Collaborator

I recently came across this rather nice way of structuring build
matrices for ci.nix.

I think it makes the haskell.nix ci.nix a lot clearer!

I recently came across this rather nice way of structuring build
matrices for ci.nix.

I think it makes the haskell.nix ci.nix a lot clearer!
@michaelpj
Copy link
Collaborator Author

Weirdly, this is much more green than the normal runs, I think because I'm not aggressively recursing into haskellNixRoots the way the old one did. I think we probably shouldn't be doing that: if you're supposed to evaluate all that stuff for haskellNixRoots, then it should have recurseForDerivation set inside it appropriately.

@hamishmack hamishmack requested a review from angerman March 18, 2020 23:29
@angerman
Copy link
Collaborator

This looks awesome!

@angerman
Copy link
Collaborator

I wish hercules would show this in some form of dimensiontal display as well, but... that get's tricky after two dimensions :-)

@angerman
Copy link
Collaborator

@michaelpj after your experience with plutus. Do we have a sensible ci.nix <-> release.nix bridge? Can we make sure we build the same derivations on both somehow?

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Mar 20, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 20, 2020

@hamishmack hamishmack merged commit 33dc7bc into master Mar 20, 2020
@iohk-bors iohk-bors bot deleted the imp/tidy-ci-nix branch March 20, 2020 07:52
@michaelpj
Copy link
Collaborator Author

Yep, it's pretty easy. I'll make you a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants