Guard against #884 by checking sha256 #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what caused #884, but this check should prevent the erroneous output from making it into the binary cache if it happens again.
michaelpj
reviewed
Oct 19, 2020
mk-local-hackage-repo/default.nix
Outdated
| @@ -24,6 +24,12 @@ export expires="4000-01-01T00:00:00Z" | |||
| ln -sf ${index} $out/01-index.tar.gz | |||
| export index_md5=$(nix-hash --flat --type md5 ${index}) | |||
| export index_sha256=$(nix-hash --flat --type sha256 ${index}) | |||
| ${ pkgs.lib.optionalString (index ? outputHash) '' | |||
There was a problem hiding this comment.
What does it mean if the attribute is missing?
There was a problem hiding this comment.
The index can come from extra-hackages and I don't think we want to require an outputHash for those. For instance the test for extra-hackages does not include one
I have added a comment to the code.
michaelpj
approved these changes
Oct 19, 2020
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
…#885) Not sure what caused input-output-hk#884, but this check should prevent the erroneous output from making it into the binary cache if it happens again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what caused #884, but this check should prevent the
erroneous output from making it into the binary cache if it happens
again.