feat(hermes): Add thread pool for wasm modules parallel execution #488

aido-mth · 2025-08-12T15:37:44Z

Description

This PR adds thread pool, which makes possible parallel execution of wasm modules. Also it provides test, which checks that execution runs in parallel.

Related Issue(s)

Closes #81

Description of Changes

Add task thread pool (wrapper around rayon thread pool)
Provided integration test to check if modules actually run in parallel
- Added component, that sleeps for 1 second per request tests/integration/components/sleep_component
- Added tests/integration/tests/serial/parallel_module_execution.rs which can be managed via cargo test
Updated hermes/bin/tests/integration/tests/serial/utils/ to be more generic in usage

Breaking Changes

Describe any breaking changes and the impact.

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module

hermes/.config/nextest.toml

hermes/bin/src/pool.rs

hermes/bin/src/app.rs

hermes/bin/src/event/queue.rs

hermes/bin/src/app.rs

hermes/bin/src/pool.rs

hermes/bin/tests/integration/components/sleep_component/src/stub.rs

hermes/bin/tests/integration/components/sleep_component/src/lib.rs

aido-mth · 2025-08-26T12:24:11Z

Now blocked by issue.

* feat(hermes): add unit test for parallel execution, rewrite integration test to use db * chore(hermes): remove env var, add comment describing the reason why we don't need it * fix(hermes): add busy_handler that always retries SQLITE_BUSY * fix(hermes): updated sqlite_busy retry delay * feat(hermes): add WAL mode * chore(hermes): link issue to TODO comment --------- Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>

rafal-ch

LGTM 👍
I left two nits.

hermes/bin/src/app.rs

hermes/bin/tests/integration/tests/serial/parallel_module_execution.rs

… magic numbers with constants

stevenj

LGTM

hermes/bin/src/pool.rs

cong-or

LGTM.

no30bit

LGTM

stevenj · 2025-09-04T15:41:08Z

hermes/bin/src/pool.rs

+use rayon::ThreadPoolBuilder;
+
+/// Global counter of currently running tasks.
+static TASK_COUNTER: AtomicUsize = AtomicUsize::new(0);


Why is it a usize? What relationship does it have to pointers or memory? Is it used for indexing?
Unless its got something to do with memory (an index or pointer math) we should pick an appropriately sized variable type so its 100% consistent regardless of platform.
Given that its actually counting concurrently running threads, it probably never needs to be bigger than u16.

stevenj · 2025-09-04T15:53:37Z

hermes/bin/src/pool.rs

+static TASK_COUNTER: AtomicUsize = AtomicUsize::new(0);
+
+/// Synchronization primitives for waiting until all tasks finish.
+static TASK_WAIT: (Mutex<()>, Condvar) = (Mutex::new(()), Condvar::new());


I feel if the aim here is to build a countdown latch, then we should have a countdown latch type which does that.
Seems like this is the sort of thing we would use in other places.
It would also be easier to test, in isolation.
would also make the intent of it here more obvious.

minikin assigned aido-mth Aug 12, 2025

aido-mth added this to Catalyst Aug 12, 2025

github-project-automation bot moved this to New in Catalyst Aug 12, 2025

aido-mth moved this from New to 🏗 In progress in Catalyst Aug 12, 2025

aido-mth added rust Pull requests that update Rust code squad: hermetics Hermes Backend, System Development & Integration Team fyi: hermetics For information - Hermes Backend, System Development & Integration Team rr: hermetics Required review by hermes team labels Aug 12, 2025

aido-mth force-pushed the aido/81/parallel_module_execution branch from f22890e to cdc7c8c Compare August 12, 2025 16:12

rafal-ch moved this from 🏗 In progress to 👀 In review in Catalyst Aug 13, 2025

aido-mth force-pushed the aido/81/parallel_module_execution branch 2 times, most recently from d7bd604 to 2ee63a6 Compare August 19, 2025 12:45

aido-mth marked this pull request as ready for review August 19, 2025 12:45

aido-mth requested review from stevenj, cong-or and rafal-ch as code owners August 19, 2025 12:45

rafal-ch reviewed Aug 19, 2025

View reviewed changes

aido-mth force-pushed the aido/81/parallel_module_execution branch from b422017 to 9ff8a43 Compare August 20, 2025 16:01

aido-mth added the review me PR is ready for review label Aug 21, 2025

cong-or reviewed Aug 21, 2025

View reviewed changes

hermes/bin/src/app.rs Outdated Show resolved Hide resolved

cong-or reviewed Aug 21, 2025

View reviewed changes

hermes/bin/src/event/queue.rs Show resolved Hide resolved

aido-mth mentioned this pull request Aug 21, 2025

[Bug]: appending to file in our VFS is not synchronized #508

Open

2 tasks

aido-mth force-pushed the aido/81/parallel_module_execution branch from 17ee679 to f64deab Compare August 22, 2025 08:04

stevenj requested changes Aug 22, 2025

View reviewed changes

hermes/bin/src/app.rs Outdated Show resolved Hide resolved

hermes/bin/src/pool.rs Outdated Show resolved Hide resolved

github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Aug 22, 2025

stevenj requested changes Aug 22, 2025

View reviewed changes

hermes/bin/tests/integration/components/sleep_component/src/stub.rs Show resolved Hide resolved

hermes/bin/tests/integration/components/sleep_component/src/lib.rs Outdated Show resolved Hide resolved

aido-mth added 3 commits August 27, 2025 10:29

feat(hermes): Add thread pool for wasm modules parallel execution

85d3d21

fix: test terminates now after receiving all expected responses

5a69cb7

fix: pool termination

e6bf15f

aido-mth added 2 commits September 2, 2025 13:52

Merge branch 'main' into aido/81/parallel_module_execution

0527920

chore(hermes): update ci version

59c67f5

aido-mth requested a review from no30bit as a code owner September 2, 2025 13:49

stevenj and others added 2 commits September 3, 2025 13:09

Merge branch 'main' into aido/81/parallel_module_execution

1f96830

rafal-ch previously approved these changes Sep 3, 2025

View reviewed changes

hermes/bin/src/app.rs Show resolved Hide resolved

hermes/bin/tests/integration/tests/serial/parallel_module_execution.rs Outdated Show resolved Hide resolved

aido-mth added 2 commits September 3, 2025 12:11

Merge branch 'main' into aido/81/parallel_module_execution

d9b3ec6

chore(hermes): refactor Arc cloning, update test comments and replace…

767b319

… magic numbers with constants

aido-mth dismissed rafal-ch’s stale review via 767b319 September 3, 2025 10:47

aido-mth requested a review from bkioshn as a code owner September 3, 2025 10:47

rafal-ch mentioned this pull request Sep 3, 2025

feat(hermes): Initialize module via direct function call, not an event #528

Merged

8 tasks

chore(hermes): remove Arc::clone

cdd0b31

stevenj requested review from stevenj, cong-or and rafal-ch September 3, 2025 12:38

rafal-ch previously approved these changes Sep 3, 2025

View reviewed changes

stevenj previously approved these changes Sep 4, 2025

View reviewed changes

Merge branch 'main' into aido/81/parallel_module_execution

b8cc119

aido-mth dismissed stale reviews from stevenj and rafal-ch via b8cc119 September 4, 2025 10:43

no30bit reviewed Sep 4, 2025

View reviewed changes

hermes/bin/src/pool.rs Show resolved Hide resolved

hermes/bin/src/pool.rs Show resolved Hide resolved

hermes/bin/src/pool.rs Show resolved Hide resolved

hermes/bin/src/pool.rs Show resolved Hide resolved

chore(hermes): removed once lock, fix dic order

bd20794

cong-or approved these changes Sep 4, 2025

View reviewed changes

no30bit approved these changes Sep 4, 2025

View reviewed changes

aido-mth merged commit a18a2b9 into main Sep 4, 2025
77 of 79 checks passed

aido-mth deleted the aido/81/parallel_module_execution branch September 4, 2025 15:46

github-project-automation bot moved this from 🔖 Ready to ✅ Done in Catalyst Sep 4, 2025

stevenj requested changes Sep 4, 2025

View reviewed changes

github-project-automation bot moved this from ✅ Done to 🔖 Ready in Catalyst Sep 4, 2025

rafal-ch moved this from 🔖 Ready to ✅ Done in Catalyst Sep 8, 2025

feat(hermes): Add thread pool for wasm modules parallel execution #488

feat(hermes): Add thread pool for wasm modules parallel execution #488

Uh oh!

Conversation

aido-mth commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Description of Changes

Breaking Changes

Please confirm the following checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aido-mth commented Aug 26, 2025

Uh oh!

rafal-ch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stevenj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cong-or left a comment

Choose a reason for hiding this comment

Uh oh!

no30bit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevenj Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

stevenj Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aido-mth commented Aug 12, 2025 •

edited

Loading