IOSim changes #117
Merged
IOSim changes #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
coot
commented
Nov 3, 2023
coot
commented
- io-sim: traceTVar for registerDelay tvars
- io-sim: labelTVarIO and traceTVarIO in ST
- io-sim: don't print the same trace twice
- io-sim: code style
- io-sim: pretty printers
As consequence we also change that `execAtomically'` like `execActomically` does not executes `commitTVar`, otherwise we'd get an error when calling `traceTVarST`.
Implemented both calls using `LiftST` rather than executing an `STM` transaction. The primary benefit is a simpler trace.
* ppSimEventType: print `Races` without duplicating `Races` twice. * ppEffect: avoid printing dangling commas. * ppSimResult: added * MainReturn, MainException: include `Labeled IOSimThreadId`, this is a cosmetic change which makes the final message of simulation fit into the same style as other messages.
coot
force-pushed
the
coot/io-sim-changes
branch
from
6b94cdc to
892ddb4
Compare
bolt12
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.