Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc 9.6 support, io-sim-1.0.0.1 #73

Merged
merged 5 commits into from
Apr 20, 2023
Merged

ghc 9.6 support, io-sim-1.0.0.1 #73

merged 5 commits into from
Apr 20, 2023

Conversation

angerman
Copy link
Contributor

@angerman angerman commented Mar 14, 2023 •
edited by coot
Loading

This PR makes it possible to compile with ghc-9.6; and bumps versions to be released on Hackage.

@coot coot force-pushed the angerman/ghc-9.6.1 branch 3 times, most recently from 2fb8c5e to 29e8bbc Compare March 22, 2023 15:56
@coot
Copy link
Collaborator

coot commented Mar 22, 2023

We now only need strict-list to relax their bounds: nikita-volkov/strict-list#1

@coot coot force-pushed the angerman/ghc-9.6.1 branch from 29e8bbc to b609dc0 Compare March 27, 2023 07:01
@coot coot force-pushed the angerman/ghc-9.6.1 branch from b609dc0 to 7e87a36 Compare April 4, 2023 10:10
@coot coot force-pushed the angerman/ghc-9.6.1 branch from 7e87a36 to 9ed87ab Compare April 20, 2023 08:41
@coot coot force-pushed the angerman/ghc-9.6.1 branch from 9ed87ab to 8f712f4 Compare April 20, 2023 08:47
@coot coot force-pushed the angerman/ghc-9.6.1 branch from e40a165 to 6fdfdbb Compare April 20, 2023 09:33
bolt12
bolt12 requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found some things that need fixing

io-sim/src/Data/Deque/Strict.hs Outdated Show resolved Hide resolved
io-sim/src/Data/Deque/Strict.hs Outdated Show resolved Hide resolved
io-sim/src/Data/Deque/Strict.hs Outdated Show resolved Hide resolved
@coot coot force-pushed the angerman/ghc-9.6.1 branch 2 times, most recently from a6ce0ed to ad15fb5 Compare April 20, 2023 10:18
bolt12
bolt12 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, I'll approve in the meantime :)

io-sim/src/Data/Deque/Strict.hs Outdated Show resolved Hide resolved
@coot coot force-pushed the angerman/ghc-9.6.1 branch 2 times, most recently from 05d6c46 to 531b7b1 Compare April 20, 2023 10:21
@coot
io-sim: remove dependency on deque package
7d17084 
It doesn't seem to be well maintained.
@coot coot force-pushed the angerman/ghc-9.6.1 branch from 531b7b1 to 7d17084 Compare April 20, 2023 10:54
@coot coot merged commit 1b117bc into main Apr 20, 2023
@coot coot deleted the angerman/ghc-9.6.1 branch April 20, 2023 17:09
@coot coot changed the title Add ghc 9.6.1 to the matrix ghc 9.6 supper, io-sim-1.0.0.1 Apr 20, 2023
@coot coot changed the title ghc 9.6 supper, io-sim-1.0.0.1 ghc 9.6 support, io-sim-1.0.0.1 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot left review comments

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Cardano Open Source Initiative
Status: Done
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angerman @coot @bolt12