Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor modifs to libsodium fork for consistency #520

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Minor modifs to libsodium fork for consistency #520

merged 1 commit into from
Jan 18, 2023

Conversation

iquerejeta
Copy link
Contributor

@iquerejeta iquerejeta commented Jan 5, 2023 •
edited
Loading

After a review of some changes in cardano base, we agreed to some minor modifications of the naming for consistency.

  • Use scalar multiplication function instead of uint_32 2d1c63
  • Declare static variables globally for VRF03 and VRF13 a23e65
  • Switch proofbytes function by bytes 08ce57
  • Use _batchcompat as suffix for consistency a5baec

@iquerejeta iquerejeta self-assigned this Jan 5, 2023
@iquerejeta iquerejeta marked this pull request as ready for review January 9, 2023 09:58
@iquerejeta iquerejeta mentioned this pull request Jan 9, 2023
Merged
angerman
angerman approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@iquerejeta
Copy link
Contributor Author

bors r+

@jbgi
Copy link
Contributor

jbgi commented Jan 18, 2023

checked locally that libsodium-vrk still build successfully.
This project need tullia/cicero setup, so merging manually.

@jbgi jbgi merged commit ccd5bf7 into master Jan 18, 2023
@angerman
Copy link
Contributor 

Loading package cardano-crypto-praos-2.1.0.0 ... 
<no location info>: error:
    <command line>: /nix/store/6i4mfgnx43sc1cim5i850ljb5zx2j03l-cardano-crypto-praos-lib-cardano-crypto-praos-2.1.0.0/lib/x86_64-linux-ghc-8.10.7/libHScardano-crypto-praos-2.1.0.0-abaUyQ5IO6I2HcF1qRDxN-ghc8.10.7.so: undefined symbol: crypto_vrf_ietfdraft03_proofbytes

cardano-crypto-praos (and probably other released libraries to CHaP) depend on crypto_vrf_ietfdraft03_proofbytes.

We need to have a migration story here. As such. I'll revert this commit for now.

@angerman angerman mentioned this pull request Jan 31, 2023
Closed
@angerman angerman mentioned this pull request May 2, 2023
Closed
@angerman angerman deleted the iquerejeta/vrf-naming branch May 16, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@iquerejeta iquerejeta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iquerejeta @jbgi @angerman