Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: shared wallets related naming improvements #1290

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Jul 15, 2024

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • shared wallets related naming improvements
  • removed circular dependency of core/transaction details components

@szymonmaslowski szymonmaslowski requested a review from a team as a code owner July 15, 2024 10:09
@szymonmaslowski szymonmaslowski force-pushed the feat/shared-wallets-naming-improvements branch from 1b2b099 to 4be0666 Compare July 15, 2024 10:40
@szymonmaslowski szymonmaslowski self-assigned this Jul 15, 2024
@szymonmaslowski szymonmaslowski force-pushed the feat/shared-wallets-naming-improvements branch from 4be0666 to cbdcdf6 Compare July 15, 2024 11:05
Base automatically changed from feat/lw-10725-add-more-field-cosigners to main July 15, 2024 11:07
@szymonmaslowski szymonmaslowski force-pushed the feat/shared-wallets-naming-improvements branch from cbdcdf6 to 6443c8b Compare July 15, 2024 11:09
@szymonmaslowski szymonmaslowski force-pushed the feat/shared-wallets-naming-improvements branch from 6443c8b to 48d47d5 Compare July 15, 2024 12:47
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Jul 15, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ❌ test report for c5f84689

passed failed skipped flaky total result
Total 32 1 0 0 33

danielmain

This comment was marked as outdated.

@szymonmaslowski szymonmaslowski enabled auto-merge (squash) July 17, 2024 09:06
Copy link

@danielmain danielmain disabled auto-merge July 17, 2024 11:55
@danielmain danielmain merged commit 9c042b2 into main Jul 17, 2024
29 of 32 checks passed
@danielmain danielmain deleted the feat/shared-wallets-naming-improvements branch July 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants