build: separate content scripts build to exclude sentry plugin [LW-13599] #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentry release tracking pollutes global scope by declaring 'e' variable, which can cause conflicts with dapp code when used in the injected script. We were NOT using sentry in the content scripts, so this has no functional effect. The reason that this code was injected is because we were using the same webpack build configuration for both: Lace app scripts and content scripts. Webpack plugins extend compiler behavior globally (applies to all entrypoints).
|
Allure Report
processReports: ❌ test report for b41027a3
|
mchappell
approved these changes
Sep 15, 2025
DominikGuzei
approved these changes
Sep 15, 2025
ljagiela
approved these changes
Sep 15, 2025
mchappell
pushed a commit
that referenced
this pull request
Sep 15, 2025
Sentry release tracking pollutes global scope by declaring 'e' variable, which can cause conflicts with dapp code when used in the injected script. We were NOT using sentry in the content scripts, so this has no functional effect. The reason that this code was injected is because we were using the same webpack build configuration for both: Lace app scripts and content scripts. Webpack plugins extend compiler behavior globally (applies to all entrypoints).
rhyslbw
pushed a commit
that referenced
this pull request
Sep 18, 2025
Sentry release tracking pollutes global scope by declaring 'e' variable, which can cause conflicts with dapp code when used in the injected script. We were NOT using sentry in the content scripts, so this has no functional effect. The reason that this code was injected is because we were using the same webpack build configuration for both: Lace app scripts and content scripts. Webpack plugins extend compiler behavior globally (applies to all entrypoints).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry release tracking pollutes global scope by declaring 'e' variable, which can cause conflicts with dapp code when used in the injected script.
We were NOT using sentry in the content scripts, so this has no functional effect. The reason that this code was injected is because we were using the same webpack build configuration for both: Lace app scripts and content scripts. Webpack plugins extend compiler behavior globally (applies to all entrypoints).
Fixes #1988
Checklist
Proposed solution
Didn't find a way to apply the plugin for select entrypoints only.
Extract content script entrypoints into a new webpack configuration and build them separately.
Testing
See #1988