Skip to content

Conversation

mchappell
Copy link
Member

@mchappell mchappell commented Sep 22, 2025

Gracefully handle (show dash or remove completely) missing fiat amounts for:

  • activities
  • activity details drawer
  • tokens list
  • tokens details
  • dapps tx and short wallet tx summary
  • send flow

both for cardano and btc wallets

https://input-output.atlassian.net/browse/LW-8256

@mchappell mchappell requested a review from a team as a code owner September 22, 2025 14:08
@lace-bot
Copy link
Collaborator

lace-bot commented Sep 22, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ❌ test report for 209daf3a

passed failed skipped flaky total result
Total 32 1 4 0 37

@vetalcore vetalcore changed the title Fix/lw 8526 fix: handle coingecko API errors [LW-8256] Sep 22, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.1% Duplication on New Code (required ≤ 3.5%)

See analysis details on SonarQube Cloud

@ljagiela ljagiela merged commit fbf58d8 into main Sep 23, 2025
63 of 71 checks passed
@ljagiela ljagiela deleted the fix/lw-8526 branch September 23, 2025 07:26
ljagiela pushed a commit that referenced this pull request Sep 23, 2025
* fix: token display if pricing data not available

* fix: display assets price data expired banner

* fix: activity display if pricing data not available

* fix: show empty dash for cardano data when balance information unavailable

* fix: btc wallet display if pricing data not available

* fix: dapp-related amount transformers fallback

* fix: token detail drawer when no token pricing available

* fix: hide fiat amount when failed to fetch the price (BTC Send Flow)

* fix: hide fiat amount when failed to fetch the price (ADA Send Flow)

* chore: fix lint/format and unit test

---------

Co-authored-by: Przemysław Włodek <przem.wlodek.github@gmail.com>
Co-authored-by: vetalcore <vetalcore@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants