fix(extension): fetch prices only while session is active [LW-13660] #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceahasegan
force-pushed
the
fix/lw-13660-query-prices-only-when-active
branch
from
9c39a02 to
233b97b
Compare
Allure Report
processReports: ✅ test report for 59be2d5d
|
mkazlauskas
approved these changes
Oct 1, 2025
| cacheNamiMetadataSubscription({ walletManager, walletRepository }); | ||
|
|
||
| export const wallet$ = walletManager.activeWallet$; | ||
| export const isSessionActive$ = pollController$.asObservable(); |
There was a problem hiding this comment.
Nit: it would be better to export it from a separate ts module (like poll-controller.ts) because it's not really part of the wallet, especially now when it's also used by other service
There was a problem hiding this comment.
done here: 61e2b5d
mirceahasegan
force-pushed
the
fix/lw-13660-query-prices-only-when-active
branch
from
61e2b5d to
59be2d5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Trigger prices fetch only if the session is active (
pollController$emits true)Testing
Manual testing on Chrome and Firefox.