Skip to content

Conversation

mirceahasegan
Copy link
Contributor

@mirceahasegan mirceahasegan commented Oct 2, 2025

Checklist


Proposed solution

Add notification to bitcoin layout too.
Reduce margin to make room for the notification icon in shared wallets.

Testing

manual tests.

Screenshots

image image

Share wallets - notifications disabled:
image

Shared wallets - notifications enabled:
image

@mirceahasegan mirceahasegan requested a review from a team as a code owner October 2, 2025 15:24
@mirceahasegan mirceahasegan self-assigned this Oct 2, 2025
@lace-bot
Copy link
Collaborator

lace-bot commented Oct 2, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for ca78e7cc

passed failed skipped flaky total result
Total 33 0 4 0 37

@mirceahasegan mirceahasegan changed the title fix(extension): add notification icon for bitcoin layout [LW-13657] fix(extension): add notification icon for bitcoin layout [LW-13657 LW-13658] Oct 2, 2025
Copy link

sonarqubecloud bot commented Oct 2, 2025

@mirceahasegan mirceahasegan requested a review from iccicci October 2, 2025 17:09
Copy link
Contributor

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same refactor in #2005 😉

NP, I'll manage the merge conflicts

@mirceahasegan mirceahasegan merged commit b93a636 into main Oct 3, 2025
27 checks passed
@mirceahasegan mirceahasegan deleted the fix/LW-13657-notification-not-visible-in-bitcoin-wallet branch October 3, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants