Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a summary of signers before the full list in explorer #1133

Closed
3 tasks done
ghost opened this issue Aug 4, 2023 · 0 comments · Fixed by #1309
Closed
3 tasks done

Display a summary of signers before the full list in explorer #1133

ghost opened this issue Aug 4, 2023 · 0 comments · Fixed by #1309
Assignees
@Alenar
Labels
D-easy Difficulty: easy good first issue 👋 Good for newcomers P-low Priority: low UX 🌞 User experience

Comments

@ghost
Copy link

ghost commented Aug 4, 2023 •
edited by Alenar
Loading

Why

As the number of signers of a snapshot increases, displaying the raw list from the show button becomes quite cumbersome:

Screenshot 2023-08-04 at 08 04 26

Furthermore, it seems what's interesting at first from an end-user perspective is a summary of the list of signers.

What

Instead of showing the full list immediately, first display some basic information like the total stake, the number of signers, and possibly the "shape" of the stake distribution. Then provide a "foldable" box to display the full list.

How

  • Make list of signers that is foldable
  • Display total stake and number of signers
  • Use the stake breakdown histogram from registered signers page
@ghost ghost added good first issue 👋 Good for newcomers D-easy Difficulty: easy P-low Priority: low devX 🌞 Developer experience labels Aug 4, 2023
@jpraynaud jpraynaud changed the title Display a summary of signers before the full list Display a summary of signers before the full list in explorer Aug 8, 2023
@jpraynaud jpraynaud removed the to-groom 🤔 Needs grooming label Oct 9, 2023
Alenar added a commit that referenced this issue Oct 19, 2023
@Alenar
Redesign explorer certificate modal [#1133]
9018e28 
* The list of signers is now hidden behind an accordeon by default.
* Some more data are shown in the left column.
* The rigth column now hold a stakes breakdown chart.

With the mainnet aggregator the list of signers is quite long, making
the UI quite cubersome, now the UI will have a fixed size as long as the
signers list is hidden (excepted for the genesis certificate that is a
little shorter because it don't have signers).
Alenar added a commit that referenced this issue Oct 19, 2023
@Alenar
Redesign explorer Pending Certificate box [#1133]
59e9092 
* The list of signers and next signers are now behind a single accordeon
  with one item for each (meaning that you can only show one of them at
  a time).
* Those items are both collapsed by default.
* This also means that the card group of the Pending Certificate has now
  two columns instead of three.
* The number of item in each signers list is displayed in paranthesis in
  the accordeon items title.

Like the certificate modal thoses lists were quite longs when querying
the mainnet aggregator, this allow to have fixed size for the pending
certificate box as long as the user don't expand them.
Alenar added a commit that referenced this issue Oct 19, 2023
@Alenar
Redesign explorer certificate modal [#1133]
53ec8d3 
* The list of signers is collapsed behind an accordion by default.
* Some more data are shown in the left column.
* The rigth column now hold a stakes breakdown chart.

With the mainnet aggregator the list of signers is quite long, making
the UI quite cubersome, now the UI will have a fixed size as long as the
signers list is hidden (excepted for the genesis certificate that is a
little shorter because it don't have signers).
Alenar added a commit that referenced this issue Oct 19, 2023
@Alenar
Redesign explorer Pending Certificate box [#1133]
83fa926 
* The list of signers and next signers are now behind a single accordion
  with one item for each (meaning that you can only show one of them at
  a time).
* Those items are both collapsed by default.
* This also means that the card group of the Pending Certificate has now
  two columns instead of three.
* The number of item in each signers list is displayed in paranthesis in
  the accordion items title.

Like the certificate modal thoses lists were quite longs when querying
the mainnet aggregator, this allow to have fixed size for the pending
certificate box as long as the user don't expand them.
@Alenar Alenar mentioned this issue Oct 19, 2023
Merged
11 tasks
Alenar added a commit that referenced this issue Oct 19, 2023
@Alenar
Redesign explorer certificate modal [#1133]
20222df 
* The list of signers is collapsed behind an accordion by default.
* Some more data are shown in the left column.
* The rigth column now hold a stakes breakdown chart.

With the mainnet aggregator the list of signers is quite long, making
the UI quite cubersome, now the UI will have a fixed size as long as the
signers list is hidden (excepted for the genesis certificate that is a
little shorter because it don't have signers).
Alenar added a commit that referenced this issue Oct 19, 2023
@Alenar
Redesign explorer Pending Certificate box [#1133]
d0f125f 
* The list of signers and next signers are now behind a single accordion
  with one item for each (meaning that you can only show one of them at
  a time).
* Those items are both collapsed by default.
* This also means that the card group of the Pending Certificate has now
  two columns instead of three.
* The number of item in each signers list is displayed in paranthesis in
  the accordion items title.

Like the certificate modal thoses lists were quite longs when querying
the mainnet aggregator, this allow to have fixed size for the pending
certificate box as long as the user don't expand them.
Alenar added a commit that referenced this issue Oct 23, 2023
@Alenar
Redesign explorer certificate modal [#1133]
d54008f 
* The list of signers is collapsed behind an accordion by default.
* Some more data are shown in the left column.
* The rigth column now hold a stakes breakdown chart.

With the mainnet aggregator the list of signers is quite long, making
the UI quite cubersome, now the UI will have a fixed size as long as the
signers list is hidden (excepted for the genesis certificate that is a
little shorter because it don't have signers).
Alenar added a commit that referenced this issue Oct 23, 2023
@Alenar
Redesign explorer Pending Certificate box [#1133]
e24b105 
* The list of signers and next signers are now behind a single accordion
  with one item for each (meaning that you can only show one of them at
  a time).
* Those items are both collapsed by default.
* This also means that the card group of the Pending Certificate has now
  two columns instead of three.
* The number of item in each signers list is displayed in paranthesis in
  the accordion items title.

Like the certificate modal thoses lists were quite longs when querying
the mainnet aggregator, this allow to have fixed size for the pending
certificate box as long as the user don't expand them.
@jpraynaud jpraynaud added UX 🌞 User experience and removed devX 🌞 Developer experience labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alenar Alenar

Labels
D-easy Difficulty: easy good first issue 👋 Good for newcomers P-low Priority: low UX 🌞 User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explorer certificates list & signers summary input-output-hk/mithril
2 participants
@Alenar @jpraynaud