Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curiecrypt/resolve flaky test #1105

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Curiecrypt/resolve flaky test #1105

merged 1 commit into from
Aug 1, 2023

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Jul 26, 2023 •
edited
Loading

Content

This PR includes the fix for the flaky test in the stm library on CI #3853.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1104

@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   6m 43s ⏱️ +7s
639 tests ±0  639 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
677 runs  ±0  677 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0db045c. ± Comparison against base commit 44557d7.

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt temporarily deployed to testing-preview July 26, 2023 17:41 — with GitHub Actions Inactive
@curiecrypt curiecrypt requested a review from iquerejeta July 27, 2023 11:58
@curiecrypt curiecrypt temporarily deployed to testing-preview July 28, 2023 10:15 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 28, 2023
View reviewed changes
mithril-stm/src/stm.rs Fixed Show fixed Hide fixed
@curiecrypt curiecrypt temporarily deployed to testing-preview July 28, 2023 11:12 — with GitHub Actions Inactive
@curiecrypt curiecrypt temporarily deployed to testing-preview July 28, 2023 11:46 — with GitHub Actions Inactive
@curiecrypt curiecrypt force-pushed the curiecrypt/resolve-flaky-test branch from b022041 to 0db045c Compare July 28, 2023 12:47
@curiecrypt curiecrypt temporarily deployed to testing-preview July 31, 2023 11:28 — with GitHub Actions Inactive
iquerejeta
iquerejeta approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iquerejeta iquerejeta merged commit 017e16c into main Aug 1, 2023
@iquerejeta iquerejeta deleted the curiecrypt/resolve-flaky-test branch August 1, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iquerejeta iquerejeta iquerejeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve flaky test in the stm library on the CI #3853
2 participants
@curiecrypt @iquerejeta