Skip to content

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 6, 2023

Content

This PR includes the display of the compression algorithm of the snapshot archive in the explorer, if it is available.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Sep 6, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/add-snapshot-compression-explorer branch from f08daec to 294b24f Compare September 6, 2023 16:51
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Test Results

    3 files  ±0    17 suites  ±0   7m 12s ⏱️ + 2m 3s
676 tests +1  676 ✔️ +1  0 💤 ±0  0 ±0 
732 runs  +1  732 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 4b8f0d3. ± Comparison against base commit df4ffe8.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview September 6, 2023 17:22 — with GitHub Actions Inactive
@jpraynaud jpraynaud changed the title Add snapshot archive compression in explorer Add snapshot archive compression algorithm in explorer Sep 7, 2023
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (just need to merge #1209 before)

@jpraynaud jpraynaud force-pushed the jpraynaud/add-snapshot-compression-explorer branch from 294b24f to 4b8f0d3 Compare September 7, 2023 07:52
@jpraynaud jpraynaud temporarily deployed to testing-preview September 7, 2023 08:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 5bbe8e5 into main Sep 7, 2023
@jpraynaud jpraynaud deleted the jpraynaud/add-snapshot-compression-explorer branch September 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants