Skip to content

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 25, 2023

Content

This PR includes the update of the signer single-signer to use anyhow.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #798

@jpraynaud jpraynaud self-assigned this Sep 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Test Results

    3 files  ±0    17 suites  ±0   6m 38s ⏱️ -18s
680 tests ±0  680 ✔️ ±0  0 💤 ±0  0 ±0 
738 runs  ±0  738 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8ec50c1. ± Comparison against base commit 65e5420.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview September 25, 2023 09:36 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, otherwise LGTM.

@jpraynaud jpraynaud force-pushed the jpraynaud/798-add-anyhow-single-signer branch from 46800b7 to 8ec50c1 Compare September 25, 2023 10:38
@jpraynaud jpraynaud temporarily deployed to testing-preview September 25, 2023 11:15 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit ea3f816 into main Sep 25, 2023
@jpraynaud jpraynaud deleted the jpraynaud/798-add-anyhow-single-signer branch September 25, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants