Skip to content

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 14, 2024

Content

This PR includes an update of the Aggregator root route response /.

Signed entity types signed by the aggregator are now listed in a new field capabilities.

{
  "open_api_version": "0.1.17",
  "documentation_url": "https://mithril.network",
  "capabilities": {
    "signed_entity_types": [
      "MithrilStakeDistribution",
      "CardanoImmutableFilesFull",
      "CardanoTransactions"
    ]
  }
}

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1496

Copy link

github-actions bot commented Feb 14, 2024

Test Results

  3 files   40 suites   9m 18s ⏱️
830 tests 830 ✅ 0 💤 0 ❌
917 runs  917 ✅ 0 💤 0 ❌

Results for commit 2c60e8a.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the ensemble/1496/add-signing-capabilities-to-aggregator-root-route branch from b2c50a5 to 64a9194 Compare February 14, 2024 13:34
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left minor comments below.

@dlachaume dlachaume force-pushed the ensemble/1496/add-signing-capabilities-to-aggregator-root-route branch from 64a9194 to 2c60e8a Compare February 14, 2024 13:41
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 14, 2024 13:52 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit fdef07e into main Feb 14, 2024
@dlachaume dlachaume deleted the ensemble/1496/add-signing-capabilities-to-aggregator-root-route branch February 14, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add signing capabilities to the root route of the aggregator
4 participants