Skip to content

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 23, 2024

Content

This PR fix a regression in our CI workflows introduced by #1521 : the tubone24/update_release don't support import by giving only the major version.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1520

@Alenar Alenar self-assigned this Feb 23, 2024
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

Test Results

  3 files  ±0   42 suites  ±0   9m 6s ⏱️ +53s
865 tests ±0  865 ✅ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f32b307. ± Comparison against base commit c65486a.

@Alenar Alenar temporarily deployed to testing-preview February 23, 2024 09:00 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 23, 2024 09:00 — with GitHub Actions Inactive
@Alenar Alenar merged commit e208fab into main Feb 23, 2024
@Alenar Alenar deleted the djo/1520/fix-release-action branch February 23, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants