Skip to content

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 26, 2024

Content

This PR includes a new blog post for the update of mithril-client-cli output.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Add dev blog post (if relevant)

@dlachaume dlachaume self-assigned this Feb 26, 2024
@dlachaume dlachaume force-pushed the damien/dev-blog-post-client-cli-output branch 2 times, most recently from 9cbd1dc to bc1e96c Compare February 26, 2024 14:48
Copy link

github-actions bot commented Feb 26, 2024

Test Results

  3 files  ±0   42 suites  ±0   8m 57s ⏱️ +30s
871 tests ±0  871 ✅ ±0  0 💤 ±0  0 ❌ ±0 
960 runs  ±0  960 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 717c09f. ± Comparison against base commit 174bc5f.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions below 🙂

@dlachaume dlachaume force-pushed the damien/dev-blog-post-client-cli-output branch from bc1e96c to b75f95c Compare February 27, 2024 08:58
@dlachaume dlachaume requested a review from Alenar February 27, 2024 08:59
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 27, 2024 09:52 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/dev-blog-post-client-cli-output branch 2 times, most recently from b94bb1e to 6b381c5 Compare February 27, 2024 10:57
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 27, 2024 11:03 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/dev-blog-post-client-cli-output branch from 6b381c5 to c6d787f Compare February 27, 2024 11:15
@dlachaume dlachaume force-pushed the damien/dev-blog-post-client-cli-output branch from c6d787f to 717c09f Compare February 27, 2024 11:18
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 27, 2024 13:15 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit e39c518 into main Feb 27, 2024
@dlachaume dlachaume deleted the damien/dev-blog-post-client-cli-output branch February 27, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants