Skip to content

docs: improve clarity in "Verify your signer is registered" section #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

docs: improve clarity in "Verify your signer is registered" section #1962

merged 1 commit into from
Sep 27, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Sep 27, 2024 •
edited
Loading

Content

This PR includes an update of the signer registration verification section in the "Run a Mithril signer as an SPO"
documentation.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

@dlachaume dlachaume self-assigned this Sep 27, 2024
@dlachaume dlachaume force-pushed the dlachaume/update-documentation branch from bec76bd to c51fbe7 Compare September 27, 2024 07:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 55s ⏱️ +18s
1 299 tests ±0  1 299 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 510 runs  ±0  1 510 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 553a280. ± Comparison against base commit fcdd144.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Sep 27, 2024
View reviewed changes
@dlachaume dlachaume force-pushed the dlachaume/update-documentation branch from c51fbe7 to 553a280 Compare September 27, 2024 09:06
@dlachaume dlachaume merged commit 2ef5f99 into main Sep 27, 2024
45 of 51 checks passed
@dlachaume dlachaume deleted the dlachaume/update-documentation branch September 27, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud