Skip to content

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Oct 2, 2024

Content

This PR adapt documentation website following the changes of #1925 (Signer compute what to sign on their own now).

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Comments

Must be merged after #1970.

Issue(s)

Relates to #1925

Copy link

github-actions bot commented Oct 2, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 36s ⏱️ +10s
1 330 tests ±0  1 330 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 541 runs  ±0  1 541 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 255d899. ± Comparison against base commit d8e4eff.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview October 2, 2024 16:57 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet October 2, 2024 16:57 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar force-pushed the djo/1925/update_docs branch from 923afbf to fb4656a Compare October 3, 2024 08:47
@Alenar Alenar temporarily deployed to testing-preview October 3, 2024 08:55 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet October 3, 2024 08:55 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/1925/update_docs branch from fb4656a to 255d899 Compare October 4, 2024 08:28
@Alenar Alenar temporarily deployed to testing-preview October 4, 2024 08:36 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet October 4, 2024 08:36 — with GitHub Actions Inactive
@Alenar Alenar merged commit 390e545 into main Oct 4, 2024
43 checks passed
@Alenar Alenar deleted the djo/1925/update_docs branch October 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants