Better folder structure for End to End test

[Alenar]

Content

This PR move into sub-directories the artifacts generated during an mithril-end-to-end run in order reduce the number of file in the work directory (that became quite packed).

Before a typical run would yield:

$ tree -L 1 /tmp/mithril-end-to-end/
Downloads/tmp/mithril-e2e-tests-artifacts-run_7180-attempt_1-mode_p2p-era_thales-cardano-9.1.1-fork-0-run_id_#1/
├── devnet
├── devnet-e11-i2.3fbf74bd9da957b719e80b562c7a845c4c87161e530c962c073bf887944865f7.tar.zst
├── devnet-e12-i2.f0b62520d4689fb37c3f8c5f611d357a2f4b0df1387fe845f6a6e67e081e5e73.tar.zst
├── devnet-e13-i2.c811e3d6e4ce658b1207ba131db4aaea2a30c7b2262239c641212d2bf2164d1e.tar.zst
├── devnet-e13-i3.c194fd6096c42dafe4788a82d11b77d26f568370fb78e08370184f80a79ff527.tar.zst
├── devnet-e14-i3.5844223f76f57434f14b2bc8df2286dc70908a89943c8fd95161888039d338c9.tar.zst
├── devnet-e15-i3.def715c7ad26914307e69a8c90e13b2b300e2481dbf75aad9691192037b6ecfa.tar.zst
├── devnet-e16-i3.a5af2e07c5c46fa81a99e587d1c0bc965959347b40d3ad7ad324ad9e975fd3fd.tar.zst
├── devnet-e17-i4.e6d25c2f93b79b749dbc92acbc9618134f79418eba9d0587bb21efd11fb4e247.tar.zst
├── devnet-e18-i4.be0ccc3d7e276a95e7bcc87f208ed58426de44eb1a4d50306c4f0323b863fe90.tar.zst
├── devnet-e19-i4.965d592b4726eed450dba53297642504c087dff486647f1f06ebae510114418b.tar.zst
├── devnet-e20-i5.237d2d827fe96bbcc994f2c02a7ab4d80dbebbed48cbf482031f413c1adbeec4.tar.zst
├── devnet-e21-i5.3f7b131ce3bdf74f36007eb7aade83ade4dbfb122b6991e15a3ae0871dfd2cfe.tar.zst
├── era.Array
├── era.thales
├── mithril-aggregator.log
├── mithril-relay-aggregator.log
├── mithril-relay-passive-1.log
├── mithril-relay-passive-2.log
├── mithril-relay-passive-3.log
├── mithril-relay-signer-pool1jekcezekdagcu7yzdjkfr6lw8727fzw6d8585638q9es7kx7a52.log
├── mithril-relay-signer-pool1snumlq5p70vlz2jmy7zx032hgea9j3t4py8rqe9vp9f52terqpg.log
├── mithril-signer-1-pool1jekcezekdagcu7yzdjkfr6lw8727fzw6d8585638q9es7kx7a52.log
├── mithril-signer-2-pool1snumlq5p70vlz2jmy7zx032hgea9j3t4py8rqe9vp9f52terqpg.log
└── stores

5 directories, 21 file

Now it yield far less files since they are moved to a artifact sub-folder:

tree -L 1 /tmp/mithril_end_to_end/
/tmp/mithril_end_to_end/
├── artifacts
├── devnet
├── mithril-aggregator.log
├── mithril-signer-1-pool1r2lney4kcl5qmvmsxsegpysrxnp0u32dngv98evwtqp05cerhaa.log
├── mithril-signer-2-pool1nhvcz4h7d4rstzpk7lnn9zcja6svpun0zrpqetg7wa0ssud0pc9.log
└── stores

4 directories, 3 files

The artifact subfolder have the following structure:

• Without era switch:

$ tree /tmp/mithril_end_to_end/artifacts/ -L 2
/tmp/mithril_end_to_end/artifacts/
├── mithril-aggregator
│   ├── devnet-e15-i3.dd0cd5ae8c5cb214f41225e30becc0b9c647ae7d0ffb5328d9ea555f7efac5b5.tar.zst
│   ├── devnet-e16-i3.bba43e5a5ca155ad4404e20083f226fd94f05ce672af15c6b688eaefc40ee72d.tar.zst
│   ├── devnet-e17-i4.37b4a36c87ff8f40bb0d36c1b44bda64243eebfc79c530bed3f0d765e278c54b.tar.zst
│   ├── devnet-e18-i4.6c1bfa476a7dcfdfcb7e17004079aca90974ad3ac88b4848721c33a12c4d7911.tar.zst
│   ├── devnet-e19-i4.2989a9d172612c79b6f535955661fadf2d95fd1e78413c6cd540afc19dbd3fd7.tar.zst
│   ├── devnet-e20-i5.53de4a3ac470f72ba2bcbef7d14b5e8ff9d14dff9794bf06051451cf44abb397.tar.zst
│   ├── devnet-e21-i5.e8739d3b19a76195699a2a4d936eab870b28869cce5e20f0f8632934f61d78ce.tar.zst
│   ├── devnet-e22-i5.d2f4858dbcdbf260e7d6be0f886d70134abdc8bc7a3e77e3ecaf70b99cba7149.tar.zst
│   ├── devnet-e23-i5.95af8cb64ee965017298d0fa6893499e19238ddcdf555c7d5656ba48b3c39e33.tar.zst
│   └── pending_snapshot
└── mithril-client
    ├── cardano_stake_distribution-22.json
    ├── db
    ├── mithril-client-cardano-db-download-d2f4858dbcdbf260e7d6be0f886d70134abdc8bc7a3e77e3ecaf70b99cba7149.out
    ├── mithril-client-csd-download-22.out
    ├── mithril-client-csd-download-478fb0cbb83c5c2f60e1736f43ef08caaa8e8143e5427a2b77f72262220316bf.out
    ├── mithril-client-ctx-certify-39e64f4b72348cc8a177e88c04916b40921343147d9525d18e4073a2d6e64d9f..1acaf6970e908775a81c954f86a931a81220a0e630b2de313b7323162518ac4f.out
    ├── mithril-client.log
    ├── mithril-client-msd-download-b66463919186d577245916a9691c7e48d83fc52811ed13ab84bd52aa70a61754.out
    └── mithril_stake_distribution-b66463919186d577245916a9691c7e48d83fc52811ed13ab84bd52aa70a61754.json

5 directories, 17 files

• With era switch:

$tree /tmp/mithril_end_to_end/artifacts/ -L 3
/tmp/mithril_end_to_end/artifacts/
├── mithril-aggregator
│   ├── devnet-e18-i4.3d459838140aa41e89221beb4ef328c5c51cbb793b843b151472bd6c0dee9f82.tar.zst
│   ├── devnet-e19-i4.5640ea8e076ee1e81200ee34651da70f2c32419a0845def4142293a58225343e.tar.zst
│   ├── devnet-e20-i5.baf236715ac8a561a95f77db125349f92719491f0d15fdf105de100c054afa15.tar.zst
│   ├── devnet-e21-i5.63051f9cb894f85efc34dfa504baa19f4b5bb564010c91f849c4760607f116dc.tar.zst
│   ├── devnet-e22-i5.c3f794cd9e7f6ecfe4598c8956479a3ca79ae37d40c0676412398d6e7887513c.tar.zst
│   ├── devnet-e23-i5.5f82771d936cf4cdddda688f230547365e861937f00f1cb0df69423680cbebdb.tar.zst
│   ├── devnet-e23-i6.b4f2b624b3ab3ac5ce36f88a624baa091f16ecf6c17d6603dcc162674a146589.tar.zst
│   ├── devnet-e24-i6.52294b6a3237bd3522c843735d2b9077109c9bd4ec50284b196cbb4ba73c161e.tar.zst
│   ├── devnet-e25-i6.cc99d391b4836f5d4c0f61ecfa933622286587cf2404ffd94964c16fce191bba.tar.zst
│   ├── devnet-e26-i6.dafc50fc70488483e237dcca5d6e1fc1a0735e73c7740b69e1371fbd2c2bf4ad.tar.zst
│   ├── devnet-e27-i7.019a64ec1e5bc72f50ec118648bc72750fd137dc0844c7710c3b31c7cb5cdf2f.tar.zst
│   ├── devnet-e28-i7.83f471370b44f405b363a111e9758a3b6c67512db77704ac63e678532e81df9d.tar.zst
│   ├── devnet-e29-i7.41050f1be662ba9925e82b2a76ab18b6e74a63b474bf4cd276d958144dfc7004.tar.zst
│   ├── devnet-e30-i8.6c6bdcce7e7185384ba78abd668be5553bffcc27b7b9828787fe23f226a0a1ba.tar.zst
│   ├── devnet-e31-i8.94e8220a5837864e5b776fa132d0e3b0c51c0d11a4a02413c093a629270f001a.tar.zst
│   └── pending_snapshot
└── mithril-client
    ├── era.pythagoras
    │   ├── cardano_stake_distribution-30.json
    │   ├── db
    │   ├── mithril-client-cardano-db-download-6c6bdcce7e7185384ba78abd668be5553bffcc27b7b9828787fe23f226a0a1ba.out
    │   ├── mithril-client-csd-download-30.out
    │   ├── mithril-client-csd-download-78cd1ed2f73cd81b573897fbb917ea93405e5a3c45ecb2dc9f8713315d76d6e0.out
    │   ├── mithril-client-ctx-certify-9b93a8daab1c214cfe085fd161d0e96ea5052db3488e189ed676925f3584d23c..fbd0ae5a1611d99da6dd36144990f1f2df1d41179ea67683c54f49d765542bab.out
    │   ├── mithril-client.log
    │   ├── mithril-client-msd-download-8ffe7837e73dcbda87921f96d517ff4bd4cbe8170378526e7ca2a5132189f5d0.out
    │   └── mithril_stake_distribution-8ffe7837e73dcbda87921f96d517ff4bd4cbe8170378526e7ca2a5132189f5d0.json
    └── era.thales
        ├── cardano_stake_distribution-24.json
        ├── db
        ├── mithril-client-cardano-db-download-cc99d391b4836f5d4c0f61ecfa933622286587cf2404ffd94964c16fce191bba.out
        ├── mithril-client-csd-download-24.out
        ├── mithril-client-csd-download-dc8c6d5aaac72bd5fe3814a03a1e431bf49790df383e270a663eaa6d83c1f31a.out
        ├── mithril-client-ctx-certify-9b93a8daab1c214cfe085fd161d0e96ea5052db3488e189ed676925f3584d23c..fbd0ae5a1611d99da6dd36144990f1f2df1d41179ea67683c54f49d765542bab.out
        ├── mithril-client.log
        ├── mithril-client-msd-download-2dc402a566682dfa6e0f136d9f8fa83fe468455c4587df46eb81bfd3d0297ec7.out
        └── mithril_stake_distribution-2dc402a566682dfa6e0f136d9f8fa83fe468455c4587df46eb81bfd3d0297ec7.json

8 directories, 31 files

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

[github-actions]

Test Results

    4 files  ±0     54 suites  ±0   9m 21s ⏱️ -18s
1 351 tests ±0  1 351 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 559 runs  ±0  1 559 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4bdc047. ± Comparison against base commit b9b227f.

♻️ This comment has been updated with latest results.

[jpraynaud]

LGTM 👍

[dlachaume]

LGTM 👍