Skip to content

Fix: rename certificate_total_produced_since_startup metric name in aggregator #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix: rename certificate_total_produced_since_startup metric name in aggregator #2040

merged 2 commits into from
Oct 22, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 22, 2024 •
edited
Loading

Content

This PR includes the renaming of certificate_total_produced_since_startup metric (leftover related to the original name).

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1980

@dlachaume dlachaume self-assigned this Oct 22, 2024
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0     55 suites  ±0   10m 33s ⏱️ -1s
1 379 tests ±0  1 379 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 593 runs  ±0  1 593 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ed7499. ± Comparison against base commit f19e6a3.

@dlachaume dlachaume temporarily deployed to testing-sanchonet October 22, 2024 13:02 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit af96205 into main Oct 22, 2024
45 checks passed
@dlachaume dlachaume deleted the dlachaume/fix-metric-name branch October 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud