Access registered signers for latest epoch in explorer #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an automatic system was added to handle those logs.
* mithril-aggregator from `0.5.95` to `0.5.96` * mithril-explorer from `0.7.13` to `0.7.14` * openapi.yaml from `0.1.34` to `0.1.35`
Alenar
force-pushed
the
djo/1689/latest_for_registered_signers
branch
from
c9cd447 to
82ce6ca
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
added a commit
that referenced
this pull request
Nov 25, 2024
Since #2062 the version of our openapi file is `3.1.1` but the action that we use (`Legion2/swagger-ui-action@v1`) is configured by default to use swaggerui version 3 or up and swagger ui is only compatible with openapi 3.1 since version 5.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR modify the aggregator
signers/registered/{epoch}route to accept not only numbers for the epoch but alsolatest. Iflatestis ask then the route handler will call the aggregator epoch service to obtain the current working epoch of the aggregator.Plus the explorer "Signers registrations" page is updated to support
latestas the epoch in its url.Note: in order to describe this change in the openapi I had to upgrade to openapi version
3.1(else I can't describe "const" parameter such aslatest).Pre-submit checklist
Issue(s)
Closes #1689