Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use io-classes 1.1.0.0 #4281

Merged
merged 2 commits into from Apr 28, 2023
Merged

Use io-classes 1.1.0.0 #4281

merged 2 commits into from Apr 28, 2023
+498 −374

Conversation

coot
Copy link
Contributor

@coot coot commented Jan 16, 2023 •
edited

Description

This PR updates ouroboros-network repository to use io-classes-1.1.0.0 (to
be published on Hackage).

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot force-pushed the coot/io-sim-1.0.0.0 branch 2 times, most recently from b6baa14 to 359f05a Compare January 16, 2023 10:32
@coot
Copy link
Contributor Author

coot commented Jan 16, 2023

The PR doesn't build since I haven't yet published io-sim and I don't want to push s-r-p in cabal.project.

@coot coot self-assigned this Jan 18, 2023
@coot
Copy link
Contributor Author

coot commented Apr 15, 2023

Depends on input-output-hk/io-sim#60.

@coot coot mentioned this pull request Apr 15, 2023
Closed
11 tasks
@michaelpj
Copy link
Contributor

The PR doesn't build since I haven't yet published io-sim and I don't want to push s-r-p in cabal.project.

I think putting an s-r-p in a draft PR to test a pre-release is a perfectly good and sensible use of s-r-ps. You probably just don't want to merge with it in.

@coot coot marked this pull request as ready for review April 19, 2023 07:45
@coot coot requested a review from nfrisby as a code owner April 19, 2023 07:45
@coot coot force-pushed the coot/io-sim-1.0.0.0 branch 4 times, most recently from 3a2c3c3 to b28f084 Compare April 21, 2023 21:57
@jasagredo
Copy link
Contributor

jasagredo commented Apr 24, 2023 •
edited

FYI @coot this is the error in CI

trace: WARNING: No sha256 found for source-repository-package https://github.com/input-output-hk/fs-sim ref=(unspecified) rev=70061b951775c053df73a74aa51de224e3a7237d download may fail in restricted mode (hydra)

@coot
Copy link
Contributor Author

coot commented Apr 25, 2023

I'll remove the s-r-p once input-output-hk/cardano-haskell-packages#225 is merged.

@coot coot force-pushed the coot/io-sim-1.0.0.0 branch 2 times, most recently from 4c9bd28 to 9f3ec03 Compare April 26, 2023 08:26
@coot coot changed the title Use io-classes 1.0.0.0 Use io-classes 1.0.0.1 Apr 26, 2023
coot added a commit that referenced this pull request Apr 26, 2023
@coot
Experimental ghc-9.6 support
68b6ce4 
Also requires #4281 (io-classes-1.0.0.1).
jasagredo
jasagredo approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ouroboros-network-api/ouroboros-network-api.cabal Show resolved Hide resolved
coot added a commit that referenced this pull request Apr 26, 2023
@coot
Experimental ghc-9.6 support
ed8b92e 
Also requires #4281 (io-classes-1.0.0.1).
@coot coot requested a review from a team as a code owner April 26, 2023 10:59
coot added a commit that referenced this pull request Apr 26, 2023
@coot
Experimental ghc-9.6 support
446e889 
Also requires #4281 (io-classes-1.0.0.1).
coot added a commit that referenced this pull request Apr 27, 2023
@coot
Experimental ghc-9.6 support
c3ff3f9 
Also requires #4281 (io-classes-1.0.0.1).
@coot coot changed the title Use io-classes 1.0.0.1 Use io-classes 1.1.0.0 Apr 27, 2023
@coot
Copy link
Contributor Author

coot commented Apr 27, 2023

bors merge

1 similar comment
@johnalotoski
Copy link

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 27, 2023

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 28, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2f7480d into master Apr 28, 2023
7 checks passed
@iohk-bors iohk-bors bot deleted the coot/io-sim-1.0.0.0 branch April 28, 2023 00:03
coot added a commit that referenced this pull request Apr 28, 2023
@coot
Experimental ghc-9.6 support
6b7cfd6 
Also requires #4281 (io-classes-1.0.0.1).
coot added a commit that referenced this pull request Apr 28, 2023
@coot
Experimental ghc-9.6 support
f1ce99e 
Also requires #4281 (io-classes-1.0.0.1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasagredo jasagredo jasagredo approved these changes

@nfrisby nfrisby Awaiting requested review from nfrisby

@bolt12 bolt12 Awaiting requested review from bolt12

@dnadales dnadales Awaiting requested review from dnadales

Assignees

@coot coot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@coot @michaelpj @jasagredo @johnalotoski @dnadales