[DDW-1037] Bump version of create-react-context #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikGuzei
previously approved these changes
Mar 31, 2022
|
@szymonmaslowski did you do a smoke test for Daedalus too? |
|
@DominikGuzei No I did not. Will do that. I will locally install RP with my change in the Daedalus and check if it starts correctly. Is that what you mean by the smoke test in this case? |
|
@DominikGuzei I did the test and it seems to work correclty. |
lucas-barros
approved these changes
Apr 12, 2022
przemyslaw-wlodek
approved these changes
Apr 12, 2022
danielmain
approved these changes
Apr 12, 2022
renanvalentin
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to eliminate vulnerability introduced by the
node-fetch< 2.6.7 we need to bump the version ofcreate-react-contextwhich currently brings the vulnerable version ofnode-fetchin its dependency tree.Changes:
create-react-contextversion from 0.2.2 to 0.3.0. It is a seamless upgrade as there is nothing that could affect thereact-polymorththat was introduced between those versions (check here)reactas this is already done by thecreate-react-context(check here)Checks:
QA Thread