Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dem_error: set cond=1e-8 to fix abnormal fit residual + add unit test #890

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Nov 6, 2022

Description of proposed changes

  • dem_error: fix abnormal residual TS with default phase velocity mode

    • estimate_dem_error(): switch cutoff value of the least squares solution from 1e-15 to 1e-8, to avoid abnormal high TS residual value, when the phase velocity mode is turned ON by default (dem_error: change default from phase to phase velocity #875). Tests (based on the new unit test) shows this change of cutoff value has no impact on the estimation result accuracy at all, which is in contrast to the brief conclusion in e28c240.
    • set debug_mode as global variable to be test a specific pixel given Y/X easily.
  • add tests/dem_error.py, to test the DEM error estimation / correction in both scenarios (simple linear and complex non-linear) for one pixel. functions/modules for unit test #402

    • add to circle CI testing
  • tropo_pyaps3: improved auto-skip/run checks

    • skip dload if ERA5.h5 already exists
    • skip re-applying correction if corrected displacement exists and is newer
    • print out msg adjustment

Reminders

  • Pass Codacy code review (green)
  • Pass Pre-commit check (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ skip dload if ERA5.h5 already exists
+ skip re-applying correction if corrected displacement exists and is newer
+ print out msg adjustment
+ dem_error: fix abnormal residual TS with default phase velocity mode
   - estimate_dem_error(): switch cutoff value of the least squares solution from 1e-15 to 1e-8, to avoid abnormal high TS residual value, when the phase velocity mode is turned ON by default. Tests shows this change has not noticeable impact on the estimation result, using the new unit test.
   - set `debug_mode` as global variable to be test a specific pixel given Y/X easily.

+ add tests/dem_error.py, to test the DEM error estimation / correction in both scenarios (simple linear and complex non-linear) for one pixel.
   - add to circle CI testing

+ ifgram_inversion: rename/shortern the default output filenames for ionStack.h5
@yunjunz yunjunz merged commit a199d92 into insarlab:main Nov 6, 2022
@yunjunz yunjunz deleted the dem_error branch November 6, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant