Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing images on curated entity pages #152

Closed
cyberandy opened this issue Nov 5, 2015 · 4 comments
Closed

Losing images on curated entity pages #152

cyberandy opened this issue Nov 5, 2015 · 4 comments
Assignees
Milestone

Comments

@cyberandy
Copy link
Member

This has been first spotted on http://www.lafabbricadellarealta.com/ and it could be reproduced as follows:

  • create a blog post x
  • select an entity y for that blog post
  • enrich the entity (by going into vocabulary > [entity-y] > edit ) with one or more images
  • get back on the blog post x
  • unselect the entity y
  • save again the blog post x so that the analysis starts again
  • select the entity y

All images in the entity page y and any other text you might have added by going into vocabulary > [entity-y] > edit are lost.

The WordLift Edit Post Widget saves the entity as a new entity and all additional contents are removed.

This is critical and very painful as in some cases we see also widgets and other valuable links being removed from entity pages. It might require a more in-depth testing to be properly reproduced.

@cyberandy cyberandy added this to the 3.1 milestone Nov 5, 2015
@mcolacino
Copy link
Contributor

Should we manage as an hotfix instead?

@ziodave
Copy link
Member

ziodave commented Nov 9, 2015

Yes

@mcolacino mcolacino self-assigned this Nov 9, 2015
@mcolacino
Copy link
Contributor

The analysis returns entity descriptions as they are on Redlink side (text plain version without html markup). The disambiguation widget generally shows the text plain version coming from Redlink. If the current entity is available in the local storage (meaning that a given entity is previously related to the current post). For the rest, the plain text version is used: this creates the bug. Looking at the workflow the unselection step that creates the bug. A solution could be avoid description overriding if the current entity is not already linked to the current post.

@cyberandy
Copy link
Member Author

An even simpler way to put this is to avoid description overriding when
the current entity is locally stored
.

Andrea Volpini

InsideOut10 http://blog.insideout.io
[image: Twitter]
http://s.wisestamp.com/links?url=http%3A%2F%2Ftwitter.com%2F%23!%2Fcyberandy&sn=
[image: LinkedIn]
http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Fvolpini&sn=
[image: about.me]
http://s.wisestamp.com/links?url=https%3A%2F%2Fabout.me%2Fandreavolpini&sn=
[image: Tumblr]
http://s.wisestamp.com/links?url=http%3A%2F%2Fblog.insideout.io&sn= [image:
Blog RSS]
http://s.wisestamp.com/links?url=http%3A%2F%2Fandrea.volpini.com&sn= [image:
Google Plus Page]
http://s.wisestamp.com/links?url=https%3A%2F%2Fplus.google.com%2F113000363475040285402%2Fposts&sn=
[image: SlideShare]
http://s.wisestamp.com/links?url=http%3A%2F%2Fslideshare.net%2Fcyberandy%2F&sn=
[image: Flickr]
http://s.wisestamp.com/links?url=http%3A%2F%2Fwww.flickr.com%2Fphotos%2Fcyberandy%2F&sn=

On Tue, Nov 10, 2015 at 11:31 AM, Marcello Colacino <
notifications@github.com> wrote:

The analysis returns entity descriptions as they are on Redlink side (text
plain version without html markup). The disambiguation widget generally
shows the text plain version coming from Redlink. If the current entity is
available in the local storage (meaning that a given entity is previously
related to the current post). For the rest, the plain text version is
used: this creates the bug
. Looking at the workflow the unselection step
that creates the bug. A solution could be avoid description overriding
if the current entity is not already linked to the current post
.


Reply to this email directly or view it on GitHub
#152 (comment)
.

mcolacino added a commit that referenced this issue Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants