-
-
Notifications
You must be signed in to change notification settings - Fork 8
Fixes integer shorthand regression #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage Summary
Diff against main
Results for commit: 314a829 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 12 suites 3s ⏱️ Results for commit 314a829. ♻️ This comment has been updated with latest results. |
ddadd94
to
06289d0
Compare
Unit Test Performance DifferenceAdditional test case details
Results for commit 1cb4cf9 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks simple but as this changes the code that use qenv
with whitin
, maybe check apps in teal.gallery or other places that might be relevant. If users relied on is.integer or something similar they might experience different behavior with this.
Please also add a test like the "original formatting and comments are preserved when expression has a srcref" on test-qenv_get_code but with 1L instead of 1 to ensure that the srcref branch also handles integer correctly with code source references (It does), checking also for is.integer
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are not passing due to a problem around line 45. I think that Reduce can be simplified, other than that I'm happy with the changes and I think ready to merge
- fix R CMD check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the checks pass feel free to merge
Pull Request
Fixes #226