Change the way IDs are created in teal_data() constructor
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' of https://github.com/insightsengineering/teal.data # Conflicts: # tests/testthat/test-get_code.R
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Update R/teal_data-datanames.R Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com> add two tests for topological_sort
…om/insightsengineering/teal.data into topological_sort@669_insertUI@main
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
…om/insightsengineering/teal.data into topological_sort@669_insertUI@main
…in_keys as they might refer to datanames that do not exist in env
…ering/teal.data into 669_insertUI@main
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
m7pr
changed the title
teal_data() constructorteal_data() constructor
gogonzo
requested changes
Aug 12, 2024
There was a problem hiding this comment.
id needs to be random. We made an exception in teal to simplify code there only. This fails a join method (duplicated @id elements are not included):
q1 <- teal_data(a = 1, code = "a <- 1")
q2 <- teal_data(b = 2, code = "b <- 2")
joined <- join(q1, q2)
get_code(joined) |> cat()
# warning('Code was not verified for reproducibility.')
# a <- 1
|
Yes, Ok! That's why I though that join could break it, but could find the code in join that does that to prove myself wrong : ) Thanks for taking a look |
|
@m7pr I think we you close it |
insights-engineering-bot
deleted the
do_not_sample_ids@669_insertUI@main
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up after insightsengineering/teal#1302 (comment) this discussion.
Results of tests