-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP orcid: pushing records to orcid #1039
Conversation
Changes Unknown when pulling 1e64660 on Panos512:orcid into * on inspirehep:invenio3*. |
# granted to it by virtue of its status as an Intergovernmental Organization | ||
# or submit itself to any jurisdiction. | ||
|
||
from inspirehep.modules.orcid.receivers import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right pattern to populate receivers? @jacquerie?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have never written a receiver. I don't know! This is how it's currently done all over the codebase, though.
Just to add what we discussed IRL that the proper scope to use is: 'scope': '/orcid-profile/read-limited /activities/update /orcid-bio/update' |
'contributor-attributes': { | ||
'contributor-role': 'AUTHOR', | ||
# One of 'ADDITIONAL', 'FIRST' | ||
'contributor-sequence': 'ADDITIONAL' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaplun Regarding this what should we do? FIRST
means main authors and ADDITIONAL
means co-authors, as far as I understood. Should we mark every author as ADDITIONAL
or should we not provide the information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
authors[0] is the FIRST, and authors[1:] are all ADDITIONAL 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! thanks
* Amends references.editors definition to be of type array of strings, rather than simply string. Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
* Maps 100/700__w to inspire_bai field. * Makes inspire_bai field searchable. * Updates demo records to have BAIs. Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
dojson: BAI support
* Adds statistics files for every collection, to describe the current usage on legacy for MARC fields and subfields. Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
dojson: repeatable statistics
* Adds the DESY maintained HEP ontology for use by invenio-classifier. Co-authored-by: Kirsten Sachs <kirsten.sachs@desy.de> Co-authored-by: Florian Schwennsen <florian.schwennsen@desy.de> Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
* Fixes `Submit` link in the navigation bar and simplifies the navigation menu to be more direct. Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
taxonomies: HEP ontology addition
* Adds module for converting XML documents via XSLT. * Adds XSLT stylesheet for arXiv OAI-PMH XML to MARCXML and authorlist XML. Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
converter: XSLT conversion module
Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
dojson: hep `license` field regex fix
* Adds back the auditing model for tracking actions in Holding Pen. Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
* Adds a utility function `get_value` to allow for dotted record key lookup. E.g. `get_value(rec, "titles.title")`. * Migrated from legacy `invenio_utils.datastructures` package. Reviewed-by: Samuele Kaplun <samuele.kaplun@cern.ch> Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
d6a9339
to
eab097e
Compare
* Compatibility changes to make use of elasticsearch-dsl. Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
global: invenio3 search compatibility
* Adds the functionality to send updated/new records to orcid. Signed-off-by: Panos Paparrigopoulos <panos.paparrigopoulos@cern.ch>
Adds the functionality to send updated/new records to orcid.
Signed-off-by: Panos Paparrigopoulos panos.paparrigopoulos@cern.ch