Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP orcid: pushing records to orcid #1039

Closed
wants to merge 19 commits into from
Closed

Conversation

Panos512
Copy link
Contributor

@Panos512 Panos512 commented Apr 8, 2016

Adds the functionality to send updated/new records to orcid.

  • Tweak the json converter's results to fully follow orcids schema.
  • Convert citations to bibtex and add them to the output json.
  • Extract the needed information of the author to push on his behalf to orcid.
  • Check json acceptance from orcid.
  • Tests.
  • Code cleanup.

Signed-off-by: Panos Paparrigopoulos panos.paparrigopoulos@cern.ch

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1e64660 on Panos512:orcid into * on inspirehep:invenio3*.

# granted to it by virtue of its status as an Intergovernmental Organization
# or submit itself to any jurisdiction.

from inspirehep.modules.orcid.receivers import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right pattern to populate receivers? @jacquerie?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually have never written a receiver. I don't know! This is how it's currently done all over the codebase, though.

@kaplun
Copy link
Contributor

kaplun commented Apr 20, 2016

Just to add what we discussed IRL that the proper scope to use is:

'scope': '/orcid-profile/read-limited /activities/update /orcid-bio/update'

'contributor-attributes': {
'contributor-role': 'AUTHOR',
# One of 'ADDITIONAL', 'FIRST'
'contributor-sequence': 'ADDITIONAL'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaplun Regarding this what should we do? FIRST means main authors and ADDITIONAL means co-authors, as far as I understood. Should we mark every author as ADDITIONAL or should we not provide the information?

Copy link
Contributor

@kaplun kaplun Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authors[0] is the FIRST, and authors[1:] are all ADDITIONAL 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! thanks

kaplun and others added 9 commits April 22, 2016 09:18
* Amends references.editors definition to be of type array of
  strings, rather than simply string.

Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
* Maps 100/700__w to inspire_bai field.

* Makes inspire_bai field searchable.

* Updates demo records to have BAIs.

Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
* Adds statistics files for every collection, to describe the current
  usage on legacy for MARC fields and subfields.

Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
* Adds the DESY maintained HEP ontology for use by invenio-classifier.

Co-authored-by: Kirsten Sachs <kirsten.sachs@desy.de>
Co-authored-by: Florian Schwennsen <florian.schwennsen@desy.de>
Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
* Fixes `Submit` link in the navigation bar and simplifies
  the navigation menu to be more direct.

Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
@Panos512 Panos512 added the WIP label Apr 27, 2016
jalavik and others added 5 commits April 27, 2016 13:17
* Adds module for converting XML documents via XSLT.

* Adds XSLT stylesheet for arXiv OAI-PMH XML to MARCXML and authorlist
  XML.

Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
converter: XSLT conversion module
Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
dojson: hep `license` field regex fix
* Adds back the auditing model for tracking actions in Holding Pen.

Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
* Adds a utility function `get_value` to allow for dotted
  record key lookup. E.g. `get_value(rec, "titles.title")`.

* Migrated from legacy `invenio_utils.datastructures` package.

Reviewed-by: Samuele Kaplun <samuele.kaplun@cern.ch>
Signed-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>
@Panos512 Panos512 force-pushed the orcid branch 2 times, most recently from d6a9339 to eab097e Compare April 28, 2016 12:49
jmartinm and others added 4 commits April 28, 2016 16:38
* Compatibility changes to make use of elasticsearch-dsl.

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
* Adds the functionality to send updated/new records to orcid.

Signed-off-by: Panos Paparrigopoulos <panos.paparrigopoulos@cern.ch>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 59.964% when pulling 6478a30 on Panos512:orcid into 502816d on inspirehep:invenio3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants