-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switched development version to v20 #1152
Conversation
eb31620
to
e2a9f38
Compare
@@ -29,7 +29,8 @@ spec: | |||
value: "default-pipeline" | |||
- name: skip-cache | |||
value: $(params.skip-cache) | |||
|
|||
- name: context | |||
value: "node-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming the default pipeline for main and PR to "node-dev". Because the build name needs to be configured in Github as well (required build to pass). If we choose a generic name, we won't need to update anything when jumping to a higher Node.js version.
@@ -108,7 +108,7 @@ resources: | |||
type: slack-notification | |||
icon: slack | |||
source: | |||
url: ((tracer-community-slack-hook)) | |||
url: ((team-nodejs-slack-hook)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new nodejs slack webhook.
I have already started to test the images. PR is RFR. |
f0818e8
to
f72d084
Compare
refs https://jsw.ibm.com/browse/INSTA-983
Now that we have resolved the issue with ESM and Node v18.18/v18.19, we can switch to Node v20.
Node v20 is LTS.