feat(collector): added support for @google-cloud/storage@6 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
basti1302
suggested changes
Mar 14, 2023
kirrg001
force-pushed
the
dependabot/npm_and_yarn/main/google-cloud/storage-6.9.4
branch
from
8e6ae21
to
ec157ac
Compare
|
Locally it works with 16.13.0, but not with 16.13.1. CI uses 16.13.1 |
kirrg001
reviewed
Mar 15, 2023
kirrg001
reviewed
Mar 15, 2023
Nothing suspicious in https://nodejs.org/en/blog/release/v16.13.1. |
kirrg001
changed the title
kirrg001
force-pushed
the
dependabot/npm_and_yarn/main/google-cloud/storage-6.9.4
branch
from
b451eaa
to
2d329ef
Compare
kirrg001
approved these changes
Mar 15, 2023
Bumps [@google-cloud/storage](https://github.com/googleapis/nodejs-storage) from 5.18.1 to 6.9.4. - [Release notes](https://github.com/googleapis/nodejs-storage/releases) - [Changelog](https://github.com/googleapis/nodejs-storage/blob/main/CHANGELOG.md) - [Commits](googleapis/nodejs-storage@v5.18.1...v6.9.4) --- updated-dependencies: - dependency-name: "@google-cloud/storage" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
So this was actually hard to fix. googleapis/nodejs-storage@77fa8d9 > refactor!: align resumable upload behavior They changed the behaviour to "resumable: true" as default. That means the google storage lib uses resumable upload technique instead of simple technique. https://github.com/googleapis/nodejs-storage/blob/main/src/file.ts#L1933 startSimpleUpload_: Takes a readable stream and pipes it to a remote file. Unlike `startResumableUpload_`, which uses the resumable upload technique, this method uses a simple upload (all or nothing). https://github.com/googleapis/nodejs-storage/blob/main/src/resumable-upload.ts#L756 TODO: add another test to enable resumable and figure out what to do with the extra http exit call.
kirrg001
force-pushed
the
dependabot/npm_and_yarn/main/google-cloud/storage-6.9.4
branch
from
2d329ef
to
f43bf07
Compare
basti1302
suggested changes
Mar 16, 2023
kirrg001
deleted the
dependabot/npm_and_yarn/main/google-cloud/storage-6.9.4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @google-cloud/storage from 5.18.1 to 6.9.4.
Release notes
Sourced from
@google-cloud/storage's releases.... (truncated)
Changelog
Sourced from
@google-cloud/storage's changelog.... (truncated)
Commits
52e4ed6chore(main): release 6.9.4 (#2155)2c97310fix: refactor createReadStream to remove unnecessary stream (#2153)4006dfetest: add debug flag for suppressing extra console messages in ssb (#2146)7054e43chore(main): release 6.9.3 (#2149)f792f25fix: reduce memory footprint of deleteFiles by utilizing getFilesStream and u...6851cd2chore(main): release 6.9.2 (#2142)cce902dfix: correctly handle if a user has no permissions when calling iam.testPermi...b2f7600test: add output format for SSB to performance tests (#2132)e757189chore(deps): update dependency nock to ~13.3.0 (#2136)5938095chore(main): release 6.9.1 (#2135)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)